Added EmergencyContact entity and CRUD for it #41

alecstincu · 2020-03-28T17:31:44Z

What does it fix?

How has it been tested?

Tested locally all endpoints.
Still have to add unit tests for everything.

vercel · 2020-03-28T17:31:50Z

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/code4ro/next-door/pbg2b3zwm
✅ Preview: https://next-door-git-fork-alecstincu-emergency-contacts.code4ro.now.sh

mischiedorian · 2020-03-28T17:44:03Z

.../main/java/com/code4ro/nextdoor/emergency/contact/controller/EmergencyContactController.java

+        return ResponseEntity.ok(savedEmergencyContact);
+    }
+
+    @DeleteMapping("/id/{id}")


I think an restful api is without id in path: ex DELETE: /api/emergency-contacts/{id}

will change both the DELETE and GET.

Also, could you add Swagger annotations?

now that it's merged the PR for Swagger, I will ^^

chalx · 2020-03-28T18:29:39Z

api/src/main/java/com/code4ro/nextdoor/emergency/contact/dto/EmergencyContactDto.java

+import lombok.Setter;
+
+@Getter
+@Setter


De ce nu folosesti direct @ Data?

Am urmarit exemplul care era in proiect, ar arata mai bine cu @DaTa intr-adevar

@Data aduce mai multe. Oare avem nevoie de tot ce aduce? eu cred ca nu

Nu iti aduce decat hashCode, equals si toString

Ceea ce te poate ajuta sa afisez in loguri exact obiectul, poate avem nevoie la un moment dat sa facem equals, mai ales daca vrem sa facem un diff si trebuie sa stim daca sunt egale sau nu. Deci nu vad o problema sa folosim @DaTa

Da, 3 lucruri pe care nu le folosesti. Adica lombok e foarte bun, dar trebuie folosit doar pentru ce ai nevoie, ca sa nu poluezi codul

chalx · 2020-03-28T18:33:00Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+
+    private final EmergencyContactRepository emergencyContactRepository;
+
+    public EmergencyContactServiceImpl(EmergencyContactRepository emergencyContactRepository) {


Sa adaugi anotarea @ Inject

Citind commentul ma gandeam ca oare cum am uitat si totusi mergea..am descoperit asta: https://docs.spring.io/spring-boot/docs/2.0.3.RELEASE/reference/html/using-boot-spring-beans-and-dependency-injection.html

O sa adaug ca in cazul in care se mai pun parametri sa nu se mai modifice.

chalx · 2020-03-28T18:34:16Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+            .collect(Collectors.toList());
+    }
+
+    private EmergencyContact mapDtoToEntity(EmergencyContactDto emergencyContactDto) {


Aici as vedea mai bine niste servicii care sa stie sa face aceste conversii. Pe viitor nu se stie cand mai avem nevoie.

Am lucrat pe un proiect cu mapstruct, stie sa genereze asta singur si ma gandeam sa il adaug :D

Eu lucrez acum la un PR in care am adaugat modelmapper

De mapstruct stiu si eu, e minimal si face treaba rapida si usoara.

chalx · 2020-03-28T18:34:26Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+            .build();
+    }
+
+    private EmergencyContactDto mapDtoToDTO(EmergencyContact emergencyContact) {


La fel ca mai sus

chalx · 2020-03-28T18:36:52Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+        Optional<EmergencyContact> dbEntity = emergencyContactRepository.findById(
+            UUID.fromString(emergencyContactDto.getId()));
+
+        if (dbEntity.isPresent()) {


Aici ai putea sa faci direct

dbEntity.map(save).map(convertToDto).orElseGet(() => save(emergencyContactDto))

chalx · 2020-03-28T18:39:27Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+        Optional<EmergencyContact> dbEntity = emergencyContactRepository.findById(
+            UUID.fromString(id));
+
+        if (dbEntity.isPresent()) {


Nu mai ai nevoie de if. Poti face direct

emergencyContactRepository.findById(UUID.fromString(id)).ifPresent(entity -> emergencyContactRepository.deleteById(UUID.fromString(id)))

chalx · 2020-03-28T18:41:24Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+            UUID.fromString(id));
+
+        if (dbEntity.isPresent()) {
+            emergencyContactRepository.deleteById(UUID.fromString(id));


Aici ai putea sa apelezi direct delete, chiar daca nu exista informatia in baza de date ( in cazul in care nu exista nu se intampla nimic ). Asa faci 2 call-uri in baza de date.

Da, nu se intampla nimic cat timp e un valid UUID. Poate ar fi buna o validare a lui in controller in acest caz.

Dar chiar si daca e invalid nu ar trebui sa se intample nimic. Pentru ca e ‘DELETE FROM table WHERE uuid=“uuidPrimit”’ si daca nu exista nu executa delete

dap, I was overengineering this :))

chalx · 2020-03-28T18:42:04Z

...in/java/com/code4ro/nextdoor/emergency/contact/service/impl/EmergencyContactServiceImpl.java

+    public EmergencyContactDto findByUUID(String id) {
+        return emergencyContactRepository.findById(UUID.fromString(id))
+            .map(this::mapDtoToDTO)
+            .orElse(null);


De ce nu returnam direct Optional decat sa introducem NPE-uri?

Good point.

…into emergency-contacts

chalx · 2020-03-28T22:16:49Z

...est/java/com/code4ro/nextdoor/emergency/contact/service/EmergencyContactServiceImplTest.java

+import org.mockito.Mock;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+@ExtendWith(MockitoExtension.class)


Poti anota atat clasa cat si metodele cu @DisplayName.
Si ar fi ok sa facem @DisplayName("Emergency contact service should) pe clasa si la fiecare metoda @DisplayName cu ce ar trebui sa se intample

chalx · 2020-03-28T22:18:08Z

...est/java/com/code4ro/nextdoor/emergency/contact/service/EmergencyContactServiceImplTest.java

+
+        List<EmergencyContactDto> result = underTest.findAll();
+
+        assertEquals(1, result.size());


Pentru partea de assert eu as merge cu https://joel-costigliola.github.io/assertj/ mi se pare mai usor de folosit si are multe chestii faine care fac partea de verificare mai usoara

Daca folosit assertj toate asserturile ar fi

asserThat(result).hasSize(1).containsOnly(Collections.singletonList(emergencyContact));

In PR-ul pentru #21, tot pe AssertJ am mers, mi se pare cel mai elegant dintre junit/hamcrest/assertj

Fix CORS

Add compose with the db

Add support for groups

chalx · 2020-03-31T11:33:38Z

api/src/main/java/com/code4ro/nextdoor/core/service/impl/MapperServiceImpl.java

+    private final ModelMapper modelMapper;
+
+    public MapperServiceImpl() {
+        this.modelMapper = new ModelMapper();


Model mapper poate fi creat cu @bean in configuration si sa il dam ca si parametru cu @Inject

chalx · 2020-03-31T11:35:02Z

api/src/main/java/com/code4ro/nextdoor/core/service/impl/MapperServiceImpl.java

+    }
+
+    private void addCustomMappings() {
+        modelMapper.createTypeMap(BaseEntity.class, BaseEntityDto.class)


Toate astea pot fi mutate acolo unde se creeaza ModelMapper.

chalx · 2020-03-31T11:35:15Z

api/src/main/java/com/code4ro/nextdoor/core/service/impl/MapperServiceImpl.java

+    }
+
+    private void addCustomTypeMaps() {
+        modelMapper.createTypeMap(Group.class, GroupDto.class)


si astea la fel

alecstincu · 2020-04-01T07:34:51Z

Will open a new PR, I think I rebased wrongly on this one and shows a lot more commits.

Added EmergencyCrud entity and CRUD for it

aad7c2f

alecstincu requested review from aniri, catileptic, georgebejan, mihairinzis and RaduCStefanescu as code owners March 28, 2020 17:31

vercel bot deployed to Preview March 28, 2020 17:31 View deployment

alecstincu changed the title ~~Added EmergencyCrud entity and CRUD for it~~ Added EmergencyContact entity and CRUD for it Mar 28, 2020

mischiedorian reviewed Mar 28, 2020

View reviewed changes

Added EmergencyCrud entity and CRUD for it

742b896

chalx reviewed Mar 28, 2020

View reviewed changes

Alexandra Tincu added 2 commits March 28, 2020 20:57

Comments for EmergencyContact and started unit tests

e2e1446

Merge branch 'emergency-contacts' of github.com:alecstincu/next-door …

6c10112

…into emergency-contacts

vercel bot deployed to Preview March 28, 2020 19:00 View deployment

More code review changes

27ff8d6

vercel bot deployed to Preview March 28, 2020 19:36 View deployment

chalx reviewed Mar 28, 2020

View reviewed changes

George Bejan and others added 11 commits March 29, 2020 11:21

Add support for groups

503207d

Add compose with the db

701100a

Fix CORS

ec59160

Merge pull request code4romania#46 from georgebejan/develop

3bbfca9

Fix CORS

Merge pull request code4romania#45 from mihairinzis/docker

79d9a05

Add compose with the db

Merge pull request code4romania#42 from georgebejan/groups

81e1e5e

Add support for groups

Added EmergencyCrud entity and CRUD for it

4f4a84b

Comments for EmergencyContact and started unit tests

b2d1184

More code review changes

822fc83

Refactored tests and used modelmapper

8b9987b

solved conflicts

53a5da8

vercel bot deployed to Preview March 31, 2020 10:57 View deployment

chalx reviewed Mar 31, 2020

View reviewed changes

alecstincu closed this Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added EmergencyContact entity and CRUD for it #41

Added EmergencyContact entity and CRUD for it #41

alecstincu commented Mar 28, 2020

vercel bot commented Mar 28, 2020 •

edited

Loading

mischiedorian Mar 28, 2020

alecstincu Mar 28, 2020

mischiedorian Mar 28, 2020

alecstincu Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

mischiedorian Mar 28, 2020

chalx Mar 28, 2020

chalx Mar 28, 2020

mischiedorian Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

georgebejan Mar 28, 2020

chalx Mar 28, 2020

chalx Mar 28, 2020

chalx Mar 28, 2020

chalx Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 28, 2020

chalx Mar 28, 2020

alecstincu Mar 30, 2020

chalx Mar 28, 2020

iccaprar Mar 29, 2020

chalx Mar 31, 2020 •

edited

Loading

chalx Mar 31, 2020

chalx Mar 31, 2020

alecstincu commented Apr 1, 2020


		private final EmergencyContactRepository emergencyContactRepository;

		public EmergencyContactServiceImpl(EmergencyContactRepository emergencyContactRepository) {


		List<EmergencyContactDto> result = underTest.findAll();

		assertEquals(1, result.size());

Added EmergencyContact entity and CRUD for it #41

Added EmergencyContact entity and CRUD for it #41

Conversation

alecstincu commented Mar 28, 2020

What does it fix?

How has it been tested?

vercel bot commented Mar 28, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chalx Mar 31, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alecstincu commented Apr 1, 2020

vercel bot commented Mar 28, 2020 •

edited

Loading

chalx Mar 31, 2020 •

edited

Loading