fix: limit job tries (#147)

code4romania · Dec 2, 2024 · 24b0b7a · 24b0b7a
1 parent aadace6
commit 24b0b7a
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 18 deletions.
diff --git a/app/Jobs/DeleteTemporaryTableData.php b/app/Jobs/DeleteTemporaryTableData.php
@@ -19,6 +19,10 @@ class DeleteTemporaryTableData implements ShouldQueue, ShouldBeUnique
 
     public int $electionId;
 
+    public $tries = 1;
+
+    public $failOnTimeout = true;
+
     /**
      * Create a new job instance.
      */

diff --git a/app/Jobs/PersistTemporaryTableData.php b/app/Jobs/PersistTemporaryTableData.php
@@ -27,6 +27,10 @@ class PersistTemporaryTableData implements ShouldQueue, ShouldBeUnique
      */
     public $timeout = 900;
 
+    public $tries = 1;
+
+    public $failOnTimeout = true;
+
     /**
      * Create a new job instance.
      */

diff --git a/app/Jobs/SchedulableJob.php b/app/Jobs/SchedulableJob.php
@@ -22,6 +22,10 @@ abstract class SchedulableJob implements ShouldQueue, ShouldBeUnique
 
     public ScheduledJob $scheduledJob;
 
+    public $tries = 1;
+
+    public $failOnTimeout = true;
+
     /**
      * Create a new job instance.
      */

diff --git a/app/Jobs/Y2024/M06/EuropeanParliament/Records/ImportAbroadRecordsJob.php b/app/Jobs/Y2024/M06/EuropeanParliament/Records/ImportAbroadRecordsJob.php
@@ -30,15 +30,7 @@ class ImportAbroadRecordsJob implements ShouldQueue
 
     public ScheduledJob $scheduledJob;
 
-    public function tries(): int
-    {
-        return 5;
-    }
-
-    public function backoff(): array
-    {
-        return [1, 5, 10, 20, 30];
-    }
+    public $tries = 1;
 
     public function __construct(ScheduledJob $scheduledJob)
     {

diff --git a/app/Jobs/Y2024/M06/EuropeanParliament/Records/ImportCountyRecordsJob.php b/app/Jobs/Y2024/M06/EuropeanParliament/Records/ImportCountyRecordsJob.php
@@ -31,15 +31,7 @@ class ImportCountyRecordsJob implements ShouldQueue
 
     public County $county;
 
-    public function tries(): int
-    {
-        return 5;
-    }
-
-    public function backoff(): array
-    {
-        return [1, 5, 10, 20, 30];
-    }
+    public $tries = 1;
 
     public function __construct(ScheduledJob $scheduledJob, County $county)
     {

diff --git a/app/Jobs/Y2024/M12/Parliament/Records/ImportAbroadRecordsJob.php b/app/Jobs/Y2024/M12/Parliament/Records/ImportAbroadRecordsJob.php
@@ -29,6 +29,8 @@ class ImportAbroadRecordsJob implements ShouldQueue, ShouldBeUnique
     use Queueable;
     use SerializesModels;
 
+    public $tries = 1;
+
     public ScheduledJob $scheduledJob;
 
     public function __construct(ScheduledJob $scheduledJob)

diff --git a/app/Jobs/Y2024/M12/Parliament/Records/ImportCountyRecordsJob.php b/app/Jobs/Y2024/M12/Parliament/Records/ImportCountyRecordsJob.php
@@ -27,6 +27,8 @@ class ImportCountyRecordsJob implements ShouldQueue, ShouldBeUnique
     use Queueable;
     use SerializesModels;
 
+    public $tries = 1;
+
     public ScheduledJob $scheduledJob;
 
     public County $county;

diff --git a/app/Jobs/Y2024/M12/Parliament/Turnouts/ImportAbroadTurnoutsJob.php b/app/Jobs/Y2024/M12/Parliament/Turnouts/ImportAbroadTurnoutsJob.php
@@ -26,6 +26,8 @@ class ImportAbroadTurnoutsJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    public $tries = 1;
+
     public ScheduledJob $scheduledJob;
 
     public function __construct(ScheduledJob $scheduledJob)

diff --git a/app/Jobs/Y2024/M12/Parliament/Turnouts/ImportCountyTurnoutsJob.php b/app/Jobs/Y2024/M12/Parliament/Turnouts/ImportCountyTurnoutsJob.php
@@ -24,6 +24,8 @@ class ImportCountyTurnoutsJob implements ShouldQueue
     use Queueable;
     use SerializesModels;
 
+    public $tries = 1;
+
     public ScheduledJob $scheduledJob;
 
     public County $county;