⚡️ Speed up function _calculate_lines_mappings
by 6% in src/black/ranges.py
#54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
_calculate_lines_mappings
insrc/black/ranges.py
✨ Performance Summary:
6%
(0.06x
faster)63.1 microseconds
down to59.6 microseconds
(best of72
runs)📝 Explanation and details
Here is the optimized version of the program.
Optimizations Made.
splitlines
insideSequenceMatcher
, we do it once at the beginning and reuse the split line lists.previous_block
only once at the start of the loop, we avoid redundantif
checks inside the loop._LinesMapping
Object Appends: Append the_LinesMapping
objects directly inside the loop without needing an additionalif
statement for the first block.previous_block
to avoid recalculating or reiterating over previous blocks.Note.
The optimized code maintains the same logic but avoids unnecessary splits, rechecks, and leverages straightforward list operations to enhance performance and clarity.
✅ Correctness verification
The new optimized code was tested for correctness. The results are listed below:
🌀 Generated Regression Tests Details
Click to view details
📣 **Feedback**
If you have any feedback or need assistance, feel free to join our Discord community: