⚡️ Speed up function parse_ast
by 3,065%
#68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 3,065% (30.65x) speedup for
parse_ast
insrc/black/parsing.py
⏱️ Runtime :
9.46 milliseconds
→299 microseconds
(best of5
runs)📝 Explanation and details
Changes made.
functools.lru_cache
on_parse_single_version
to avoid redundant parsing of the same source string.type_comments
conditions and versions together for better performance and readability.reversed(versions)
for clarity and avoid calculating the sorted list multiple times.✅ Correctness verification report:
🌀 Generated Regression Tests Details
📢 Feedback on this optimization?