Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: argo cd 2.13.2 #369

Merged
merged 1,169 commits into from
Jan 9, 2025
Merged

chore: argo cd 2.13.2 #369

merged 1,169 commits into from
Jan 9, 2025

Conversation

oleksandr-codefresh
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

crenshaw-dev and others added 30 commits August 15, 2024 07:29
@crenshaw-dev
chore: remove unused params (argoproj#19473)
6aa4de6 
* chore: remove unused params

Signed-off-by: Michael Crenshaw <[email protected]>

* more

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
@Ezzahhh
fix: selfHeal should always be respected with Multi-Source Apps argop…
5a7bf2e 
…roj#19452 (argoproj#19512)

* fix(controller): selfHeal respected in multi-source apps
when there is object change in cluster

Signed-off-by: Eric Lin <[email protected]>

* fix: tests for multi source selfheal

Signed-off-by: Ezzahhh <[email protected]>

---------

Signed-off-by: Eric Lin <[email protected]>
Signed-off-by: Ezzahhh <[email protected]>
@dependabot
chore(deps): bump library/registry in /test/container (argoproj#19207)
1ce5824 
Bumps library/registry from `79b2959` to `1212042`.

---
updated-dependencies:
- dependency-name: library/registry
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@jparsai
fix: notifications triggered from CLI fails for repo functions (argop…
6ed7410 
…roj#19213)

Signed-off-by: Jayendra Parsai <[email protected]>
Co-authored-by: Jayendra Parsai <[email protected]>
@pasha-codefresh @nekia @todaywasawesome
feat: Support context switch for argocd-util (argoproj#19549)
116180b 
* feat: Support context switch for argocd-util

Signed-off-by: Atsushi Neki <[email protected]>

* execute codegen

Signed-off-by: pashakostohrys <[email protected]>

---------

Signed-off-by: Atsushi Neki <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Signed-off-by: pasha-codefresh <[email protected]>
Signed-off-by: pashakostohrys <[email protected]>
Co-authored-by: Atsushi Neki <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
@ishitasequeira
fix appset-in-any-namespace issue with git generators (argoproj#19553)
ab1d5b6 
Signed-off-by: Ishita Sequeira <[email protected]>
@ilia-medvedev-codefresh
chore: add e2e test for admin import & export (argoproj#19564)
47bcb09
@emirot
docs: fix typo (argoproj#19567)
a0624f0 
Signed-off-by: Nolan Emirot <[email protected]>
@dependabot
chore(deps): bump bitnami/kubectl from 1.30 to 1.31 in /test/container (
014f442 
argoproj#19541)

Bumps bitnami/kubectl from 1.30 to 1.31.

---
updated-dependencies:
- dependency-name: bitnami/kubectl
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @jannfis
chore(deps): bump github.com/prometheus/client_golang (argoproj#19544)
e7beda0 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.19.1 to 1.20.0.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.19.1...v1.20.0)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jann Fischer <[email protected]>
@eugene70
fix: 'argocd admin settings rbac can' - yaml loading problem(argoproj…
d82a746 
…#19403) (argoproj#19575)

fixes: argoproj#19403

Signed-off-by: Eugene Kim <[email protected]>
@jjghali
docs: Added SecurityGroup for groups TokenIDClaims (argoproj#19591)
de53d8e 
Signed-off-by: Joshua Ghali <[email protected]>
@the-technat
feat: add proxy to kustomize build operations (argoproj#18551)
74af92f 
Signed-off-by: Nathanael Liechti <[email protected]>
@the-technat
feat: allow no_proxy to be specified on repoCreds (argoproj#18526)
bacdced 
Signed-off-by: Nathanael Liechti <[email protected]>
@crenshaw-dev
ci: upload test results to codecov (argoproj#19476)
82003a2 
* feat(ci): upload test results to codecov

Signed-off-by: Michael Crenshaw <[email protected]>

* only run on master

Signed-off-by: Michael Crenshaw <[email protected]>

---------

Signed-off-by: Michael Crenshaw <[email protected]>
@dependabot
chore(deps): bump github.com/prometheus/client_golang (argoproj#19609)
44072bb 
Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.20.0 to 1.20.1.
- [Release notes](https://github.com/prometheus/client_golang/releases)
- [Changelog](https://github.com/prometheus/client_golang/blob/v1.20.1/CHANGELOG.md)
- [Commits](prometheus/client_golang@v1.20.0...v1.20.1)

---
updated-dependencies:
- dependency-name: github.com/prometheus/client_golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ilia-medvedev-codefresh
fix: appset register rollout progressing status and correct parameter…
f970249 
…sgenerated status to prevent update loop (argoproj#19613)

* fix status and update loop

Signed-off-by: Ilia Medvedev <[email protected]>

* add tests

Signed-off-by: Ilia Medvedev <[email protected]>

* lint

Signed-off-by: Ilia Medvedev <[email protected]>

---------

Signed-off-by: Ilia Medvedev <[email protected]>
@agaudreault
feat(dex): set logger based on argo config (argoproj#13191) (argoproj…
effbdc9 
…#19608)

* feat(dex): set logger based on argo config

Signed-off-by: Alexandre Gaudreault <[email protected]>

* add env config

Signed-off-by: Alexandre Gaudreault <[email protected]>

* organize import bug?

Signed-off-by: Alexandre Gaudreault <[email protected]>

---------

Signed-off-by: Alexandre Gaudreault <[email protected]>
@ishitasequeira @todaywasawesome
mark multiple sources feature as stable (argoproj#19594)
f28323b 
Signed-off-by: Ishita Sequeira <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
@JessieTeng89
fix dark mode logs fullscreen display not properly (argoproj#19505)
ea25279 
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
@Junseokee
docs: fix stable message (argoproj#19334)
7d53ef1 
* docs: fix stable message

Signed-off-by: Junseokee <[email protected]>

* docs: fix stable message

Signed-off-by: Junseokee <[email protected]>

---------

Signed-off-by: Junseokee <[email protected]>
@JessieTeng89
improve filter component color contrast (argoproj#19468)
69ef68f 
Signed-off-by: Jessie Teng <[email protected]>
Co-authored-by: Jessie Teng <[email protected]>
@jenting @todaywasawesome
fix: cache helm-index in Redis cluster (argoproj#12314) (argoproj#19530)
80f2043 
* fix: cache helm-index in Redis cluster

Signed-off-by: JenTing Hsiao <[email protected]>

* Update repository.go

Fix order

Signed-off-by: Dan Garfield <[email protected]>

---------

Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Dan Garfield <[email protected]>
Co-authored-by: Dan Garfield <[email protected]>
@keithchong
fix: Floating title content incorrect for multi-sources (argoproj#17274…
d1c74ac 
…) (argoproj#19623)

Signed-off-by: Keith Chong <[email protected]>
@corneliusroemer
doc: fix bullet rendering in config-management-plugin-v2.md (argoproj…
0179805 
…#19626)

Bullets need to start with blank line, otherwise they don't render on read the docs. GitHub markdown doesn't require them but read the docs does

Signed-off-by: Cornelius Roemer <[email protected]>
@carlosrejano
fix(appset): migrateStatus updates appset pointer after updating (arg…
5dd6020 
…oproj#19619)

# Context:
  `migrateStatus` updates the status of the appset but after succeeding
  it does not update the in memory object which means that that new
  updates may fail due to conflict since it's comparing it to the
  object previous to updating it in `migrateStatus`.

  # What does this PR?
  - After updating the appset object in `migrateStatus` it gets the
    object again to reference it in the appset pointer of the
    reconciler.

Signed-off-by: Carlos Rejano <[email protected]>
@imwithye
fix(argoproj#16842): system level extensions not working properly (ar…
085cc6c 
…goproj#19612)

* use event to notify extensions changes

Signed-off-by: Yiwei Gong <[email protected]>

* use custom event target implementation

Signed-off-by: Yiwei Gong <[email protected]>

---------

Signed-off-by: Yiwei Gong <[email protected]>
@dependabot
chore(deps): bump library/golang in /test/container (argoproj#19540)
9fc5f14 
Bumps library/golang from `a400dc7` to `8e529b6`.

---
updated-dependencies:
- dependency-name: library/golang
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@andrii-korotkov-verkada
chore: Cleanup some timing checkpoints (argoproj#19517)
b6551cd 
Adding same checkpoint in a loop would be misleading with multiple sources, also unmarshal checkpoint has a wrong name if there's a loop.
Remove checkpoints in the loop and rename the unmarshal checkpoint.

Signed-off-by: Andrii Korotkov <[email protected]>
@crenshaw-dev
fix(appset): informer is not a kubernetes informer (argoproj#18905) (a…
3cdce83 
…rgoproj#19618)

Signed-off-by: Michael Crenshaw <[email protected]>
austin5219 and others added 23 commits November 7, 2024 15:47
@austin5219
fix(pkce): 20202 Backport PKCE auth flow fix for basehref and reauth (a…
449e693 
…rgoproj#20675)

* fix(pkce): 20111 PKCE auth flow does not return user to previous path like dex auth flow (argoproj#20202)

* Adding non-default basehref support for PKCE auth flow

Signed-off-by: austin5219 <[email protected]>

* Adding ; for linting

Signed-off-by: austin5219 <[email protected]>

* removing hook function

Signed-off-by: austin5219 <[email protected]>

* Moving unauthorized error handling to class component to access context for error handling within 401 error

Signed-off-by: austin5219 <[email protected]>

* Store the subsrition handle to close in unmount

Signed-off-by: austin5219 <[email protected]>

* reorder imports

Signed-off-by: austin5219 <[email protected]>

* Actually saving the subscriptions now

Signed-off-by: austin5219 <[email protected]>

* returning the 401 subscription from helper function

Signed-off-by: austin5219 <[email protected]>

* Handle the promise of a subscription

Signed-off-by: austin5219 <[email protected]>

* Removing then from non async subscribe

Signed-off-by: austin5219 <[email protected]>

* Linter fixes

Signed-off-by: austin5219 <[email protected]>

* Adding path caching to sessionStorage on pkceLogin and redirect step to cached path if available in pkceCallback to mirror Dex functionality

Signed-off-by: austin5219 <[email protected]>

---------

Signed-off-by: austin5219 <[email protected]>

* Merge Conflict fix

Signed-off-by: austin5219 <[email protected]>

---------

Signed-off-by: austin5219 <[email protected]>
@gcp-cherry-pick-bot @andrii-korotkov-verkada
chore: Don't degrade PDB on InsufficientPods (argoproj#20171) (argopr…
7f45c9e 
…oj#20665) (argoproj#20694)

Closes argoproj#20171

There are valid use cases for InsufficientPods, e.g. running some jobs or tests that don't want to be terminated. See the discussion on the issue for more details. So don't degrade the PDB on InsufficientPods condition.

This needs to be cherry picked to 2.13, as many people may not upgrade otherwise.

Signed-off-by: Andrii Korotkov <[email protected]>
Co-authored-by: Andrii Korotkov <[email protected]>
@pasha-codefresh @nitishfy @CefBoud
fix: disable automaxprocs logging (argoproj#20069) - cherry-pick 2.13 (…
d03ccf3 
…argoproj#20718)

* fix: disable automaxprocs logging (argoproj#20069)

* disable automaxprocs logging

Signed-off-by: nitishfy <[email protected]>

fix lint checks

Signed-off-by: nitishfy <[email protected]>

move maxprocs to main.go

Signed-off-by: nitishfy <[email protected]>

move set auto max procs to a function

Signed-off-by: nitishfy <[email protected]>

add info log

Signed-off-by: nitishfy <[email protected]>

* add info log

Signed-off-by: nitishfy <[email protected]>

* fix lint checks

Signed-off-by: nitishfy <[email protected]>

* fix lint checks

Signed-off-by: nitishfy <[email protected]>

* add unit test

Signed-off-by: nitishfy <[email protected]>

* fix lint issues

Signed-off-by: nitishfy <[email protected]>

---------

Signed-off-by: nitishfy <[email protected]>
(cherry picked from commit cfa1c89)

* fix(ci): ignore temporary files when checking for out of bound symlinks (argoproj#20527)

Signed-off-by: cef <[email protected]>

---------

Signed-off-by: cef <[email protected]>
Co-authored-by: Nitish Kumar <[email protected]>
Co-authored-by: ABBOUD Moncef <[email protected]>
@Jack-R-lantern
feat: option to disable writing k8s events(argoproj#18205) (argoproj#…
6a8cb6e 
…18441) (argoproj#20788)

* feat: option to disable writing k8s events

optioned to write logs for k8s events.
Each is passed as an environment variable and defaults to true,
disabling it requires explicitly setting the option to false.

---------

Signed-off-by: Jack-R-lantern <[email protected]>
@gcp-cherry-pick-bot @andrii-korotkov-verkada
fix: Fix repeated 403 due to app namespace being undefined (argoproj#…
68606c6 
…20699) (argoproj#20819) (argoproj#20860)

Fixes argoproj#20699

Constructor may not get called every time the application changes, so previous this.appNamespace could be stale. But the update to use `this.props.match.params.appnamespace` could also fail if it's undefined.
As a fix, create and use a helper function `getAppNamespace` which has a special case handling for undefined.

Also, use a namespaced endpoint when namespace is not undefined.

It needs to be cherry-picked to v2.11-2.13.

Signed-off-by: Andrii Korotkov <[email protected]>
Co-authored-by: Andrii Korotkov <[email protected]>
@github-actions @pasha-codefresh
Bump version to 2.13.1 (argoproj#20865)
af54ef8 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: pasha-codefresh <[email protected]>
@gcp-cherry-pick-bot @OpenGuidou
fix(cli): Fix appset generate in --core mode (argoproj#20717) (argopr…
ad36916 
…oj#20883)

Signed-off-by: OpenGuidou <[email protected]>
Co-authored-by: OpenGuidou <[email protected]>
@gcp-cherry-pick-bot @dependabot
chore(deps): bump http-proxy-middleware from 2.0.4 to 2.0.7 in /ui (a…
0680ddb 
…rgoproj#20518) (argoproj#20892)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@gcp-cherry-pick-bot @AJChandler
fix: Memory leak in repo-server (argoproj#20876) (argoproj#20894)
f8d6665 
Signed-off-by: Adam Chandler <[email protected]>
Co-authored-by: Adam Chandler <[email protected]>
@gcp-cherry-pick-bot @alexmt
fix: API server should not attempt to read secrets in all namespaces (a…
831e452 
…rgoproj#20950) (argoproj#20960)

* fix: api server is trying to list cluster wide secrets while generating apps



* Revert "fix: Fix argocd appset generate failure due to missing clusterrole (argoproj#20162)"

This reverts commit fad534b.

---------

Signed-off-by: Alexander Matyushentsev <[email protected]>
Co-authored-by: Alexander Matyushentsev <[email protected]>
@gcp-cherry-pick-bot @andrii-korotkov-verkada
fix: Bitbucket Cloud PR Author is processed correctly (argoproj#20769) (
89ef356 
argoproj#20990) (argoproj#21039)

Fixes argoproj#20769

Author there is a struct, not a string. Use nickname from that struct as an author name.

Let's cherry pick to 2.11-2.13

Signed-off-by: Andrii Korotkov <[email protected]>
Co-authored-by: Andrii Korotkov <[email protected]>
@gcp-cherry-pick-bot @ishitasequeira
fix: 20791 - sync multi-source application out of order source syncs …
01ae20d 
…(cherry-pick argoproj#21071) (argoproj#21077)

Signed-off-by: Ishita Sequeira <[email protected]>
Co-authored-by: Ishita Sequeira <[email protected]>
@gcp-cherry-pick-bot @andrii-korotkov-verkada
fix: Allow to delete repos with invalid urls (argoproj#20921) (argopr…
a3624a3 
…oj#20975) (argoproj#21116)

* fix: Allow to delete repos with invalid urls (argoproj#20921)

Fixes argoproj#20921

Normalization of repo url is attempted during repo deletion before comparison with existing repos. Before this change, it'd fail on invalid urls and return "", resulting in permission denied. This ended up in a state where people can add repos with invalid urls but couldn't delete them. Return raw repo url if url parsing failed. Add a test to validate the deletion can be performed and make sure it fails without the main change.

This needs to be cherry-picked to v2.11-2.13



* Don't modify the original NormalizeGitURL



---------

Signed-off-by: Andrii Korotkov <[email protected]>
Co-authored-by: Andrii Korotkov <[email protected]>
@blakepettersson
fix: add missing fields in listrepositories (argoproj#20991) (argopro…
b6af657 
…j#21129)

This fixes a regression in 2.12. Before 2.12 githubAppInstallationID,
`githubAppID` and `gitHubAppEnterpriseBaseURL` were returned, but with
2.12 the repo is retrieved with getRepositories`, which does not
include those fields.

To fix this, add those missing fields to `ListRepositories`.

Signed-off-by: Blake Pettersson <[email protected]>
@github-actions @ishitasequeira
Bump version to 2.13.2 (argoproj#21133)
dc43124 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ishitasequeira <[email protected]>
@adriananeci
fix: Populate destination name when destination server is specified (a…
079754c 
…rgoproj#21063) (cherry-pick 2.13) (argoproj#21176)

* fix: Populate destination name when destination server is specified (argoproj#21063)

* Populate destination name when destination server is specified

Signed-off-by: Adrian Aneci <[email protected]>

---------

Signed-off-by: Adrian Aneci <[email protected]>

* Go lint fixes

Signed-off-by: Adrian Aneci <[email protected]>

---------

Signed-off-by: Adrian Aneci <[email protected]>
@gcp-cherry-pick-bot @crenshaw-dev
fix(api): send to closed channel in mergeLogStreams (argoproj#7006) (a…
f260510 
…rgoproj#21178) (argoproj#21187)

* fix(api): send to closed channel in mergeLogStreams (argoproj#7006)



* more intense test



* even more intense



* remove unnecessary comment



* fix the race condition



---------

Signed-off-by: Michael Crenshaw <[email protected]>
Co-authored-by: Michael Crenshaw <[email protected]>
@gcp-cherry-pick-bot @OpenGuidou
fix(appset): Fix appset generate in --core mode for cluster gen (argo…
09eede0 
…proj#21170) (argoproj#21236)

Signed-off-by: OpenGuidou <[email protected]>
Co-authored-by: OpenGuidou <[email protected]>
@oleksandr-codefresh
merge upstream 2.13.2
f087fad
@crenshaw-dev @linghaoSu
fix(ui): add optional check to avoid undefined reference in project d…
64a14a0 
…etail (argoproj#20044) (argoproj#21263)

Signed-off-by: linghaoSu <[email protected]>
Co-authored-by: Linghao Su <[email protected]>
@gcp-cherry-pick-bot @amit-o @agaudreault
fix: Change applicationset generate HTTP method to avoid route confli…
c76a131 
…cts (argoproj#20758) (argoproj#21300)

* Change applicationset generate HTTP method to avoid route conflicts



* Update server/applicationset/applicationset.proto




* Codegen



---------

Signed-off-by: Amit Oren <[email protected]>
Signed-off-by: Amit Oren <[email protected]>
Co-authored-by: Amit Oren <[email protected]>
Co-authored-by: Alexandre Gaudreault <[email protected]>
@github-actions @crenshaw-dev
Bump version to 2.13.3 (argoproj#21359)
a25c8a0 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: crenshaw-dev <[email protected]>
@oleksandr-codefresh
fix broken after merge unit tests
bac28c1
@oleksandr-codefresh oleksandr-codefresh force-pushed the chore/CR-26736-argo-cd-2.13.2 branch from 7255f22 to bac28c1 Compare January 7, 2025 18:51
@oleksandr-codefresh
deleted docs file with to fix failure with 'Check changes to generate…
78e96cb 
…d code'
@oleksandr-codefresh
updated CHANGELOG.md
af4dd3c
@oleksandr-codefresh
Merge branch 'tag-2.13.3' into chore/CR-26736-argo-cd-2.13.2
517b760 
# Conflicts:
#	VERSION
#	manifests/base/kustomization.yaml
#	manifests/core-install.yaml
#	manifests/core-install/kustomization.yaml
#	manifests/ha/base/kustomization.yaml
#	manifests/ha/install.yaml
#	manifests/ha/namespace-install.yaml
#	manifests/install.yaml
#	manifests/namespace-install.yaml
#	server/application/logs.go
#	server/application/logs_test.go
@oleksandr-codefresh
source version 2.13.3
4b80a67
@oleksandr-codefresh oleksandr-codefresh merged commit 67d01f9 into release-2.13 Jan 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmaizel dmaizel dmaizel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.