Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove deprecated Config\Format::getFormatter() #9405

Merged
merged 2 commits into from
Jan 13, 2025
Merged

refactor: Remove deprecated Config\Format::getFormatter() #9405

merged 2 commits into from
Jan 13, 2025

Conversation

neznaika0
Copy link
Contributor

Description
See #3563 v4.0.5

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@michalsn michalsn added refactor Pull requests that refactor code 4.6 labels Jan 12, 2025
@neznaika0 neznaika0 force-pushed the refactor/rm-deprecated-formatter branch from 1f5fc53 to 2408d07 Compare January 12, 2025 20:46
@paulbalandan paulbalandan added the stale Pull requests with conflicts label Jan 13, 2025
@neznaika0 neznaika0 force-pushed the refactor/rm-deprecated-formatter branch from 2408d07 to a793d62 Compare January 13, 2025 04:43
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Jan 13, 2025
@github-actions github-actions bot added the stale Pull requests with conflicts label Jan 13, 2025
@github-actions GitHub Actions
Copy link

👋 Hi, @neznaika0!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@neznaika0 neznaika0 force-pushed the refactor/rm-deprecated-formatter branch from a793d62 to de167a1 Compare January 13, 2025 05:46
@paulbalandan paulbalandan removed the stale Pull requests with conflicts label Jan 13, 2025
@paulbalandan paulbalandan merged commit 35321ac into codeigniter4:4.6 Jan 13, 2025
50 checks passed
@neznaika0 neznaika0 deleted the refactor/rm-deprecated-formatter branch January 13, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.6 refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@neznaika0 @michalsn @paulbalandan