Fix bug with plugin security policy for GeoJSON output #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fulups
commented
Dec 11, 2020
fulups
commented
- fix bug with plugin security policy for GeoJSON output
- update tests to correctly support variable docNumber
add support for new json object list output format
# Conflicts: # README.md # src/main/java/org/codelibs/elasticsearch/df/content/ContentType.java # src/main/java/org/codelibs/elasticsearch/df/rest/RestDataAction.java # src/test/java/org/codelibs/elasticsearch/df/DataFormatPluginTest.java
# Conflicts: # src/main/java/org/codelibs/elasticsearch/df/content/geojson/GeoJsonContent.java # src/test/java/org/codelibs/elasticsearch/df/DataFormatPluginTest.java
marevol
reviewed
Dec 13, 2020
| @@ -366,15 +377,6 @@ public void dumpJson() throws IOException { | |||
| assertTrue(lines[1].startsWith("{\"aaa\":\"test 1\",")); | |||
| } | |||
|
|
|||
| // Download 10 docs as JSON | |||
There was a problem hiding this comment.
Why did you remove this code?
marevol
reviewed
Dec 13, 2020
| @@ -193,7 +196,9 @@ public void dumpCsvWithQuery() throws IOException { | |||
| // Download All as CSV with Query and from | |||
| try (CurlResponse curlResponse = EcrCurl.get(node, "/dataset0/_data") | |||
| .header("Content-Type", "application/json") | |||
| .param("format", "csv").body(queryWithFrom).execute()) { | |||
| .param("format", "csv") | |||
| .param("size", Integer.toString(docNumber)) | |||
| @@ -204,6 +209,7 @@ public void dumpCsvWithQuery() throws IOException { | |||
| .header("Content-Type", "application/json") | |||
| .param("format", "csv").param("source", queryWithFrom) | |||
| .param("source_content_type", "application/json") | |||
| .param("size", String.valueOf(docNumber)) | |||
| @@ -168,14 +170,15 @@ public void dumpCsvWithQuery() throws IOException { | |||
| assertLineContains(lines[0], "\"aaa\"", "\"bbb\"", "\"ccc\"", "\"eee.fff\"", "\"eee.ggg\""); | |||
| assertLineContains(lines[1], "\"1\""); | |||
| } | |||
|
|
|||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.