forked from NVIDIA/cutlass
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PVC Example #74
Merged
aacostadiaz
merged 13 commits into
codeplaysoftware:sycl-develop
from
AD2605:atharva/pvc_batch_size_bug
May 27, 2024
Merged
Fix PVC Example #74
aacostadiaz
merged 13 commits into
codeplaysoftware:sycl-develop
from
AD2605:atharva/pvc_batch_size_bug
May 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tware#16) * Updating README-sycl.md to capture the 3.5 modifications * Update README-sycl.md Co-authored-by: aacostadiaz <[email protected]> * Remove the sgemm_nt_1_sycl PoC (codeplaysoftware#15) * Remove sgemm_nt_1 PoC * Fix build issues * Fix code style format * Remove ENABLE_NVPTX flag * Update include/cute/util/debug.hpp Co-authored-by: Mehdi Goli <[email protected]> * Cosmetic --------- Co-authored-by: Mehdi Goli <[email protected]> * Applying the comments --------- Co-authored-by: aacostadiaz <[email protected]>
aacostadiaz
approved these changes
May 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!!!
muhammad-tanvir-1211
approved these changes
May 27, 2024
aacostadiaz
added a commit
that referenced
this pull request
Jul 16, 2024
Fixes PVC Example which gives wrong results for batch size greater than 16 --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
aacostadiaz
added a commit
to aacostadiaz/cutlass-fork
that referenced
this pull request
Aug 6, 2024
Fixes PVC Example which gives wrong results for batch size greater than 16 --------- Co-authored-by: Mehdi Goli <[email protected]> Co-authored-by: aacostadiaz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes PVC Example which gives wrong results for batch size greater than 16