Correct private memory allocations in the SCLA path #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gle benchmark version * The Google Benchmark code does not work if CMAKE_CXX_FLAGS include -fsycl due to conflicting C++ version requirements. * This removes the external CXX flags for the Google Benchmark library build. * Also update Google Benchmark version tag.
…o atharva/correct_wi_temp_allocations
|
@victor-eds , if you could post the log of passing tests, and speed-up observed using the SCLA path 🙏🏻 |
hjabird
reviewed
Aug 14, 2024
|
I ran the tests both on PVC and an iGPU earlier this week and they worked. Performance wise, PVC:
We see one of the benchmarks benefits with a 1.25x speedup thanks to this patch. |
Rbiessy
reviewed
Aug 16, 2024
Oh you mean #149 ? |
Yes you may want to revert this change if you want to merge this PR soon. |
hjabird
previously approved these changes
Aug 16, 2024
…date Google benchmark version" This reverts commit 99184a2.
Done |
hjabird
approved these changes
Aug 16, 2024
Rbiessy
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the allocation size of the private arrays in the SCLA path, which was otherwise leading to spills and hence poor performance even when using SCLAs.
Also brings in a minor fix in the benchmarks. Turns out we were only reporting the last value instead of the average.
tag @victor-eds
tag @Rbiessy @hjabird
Already Merges: #149
Checklist
Tick if relevant: