Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand environment variable defined in defaults.json #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Benjamin-Tan
Copy link

This is to allow defaults.json to reference an environment variable.

This is to allow defaults.json to reference an environment variable.
@cottsay
Copy link
Member

cottsay commented Oct 4, 2023

I think this would constitute a breaking change as-is, and would behave differently on Windows where environment variables are denoted with % rather than $. That would imply that defaults files which use this mechanism wouldn't be cross-platform anymore.

Even though this improves the flexibility of defaults files, I think it could hinder debugging problems substantially.

@Benjamin-Tan
Copy link
Author

To have cross-platform compatibility, how about having a helper function to support for both $ and %?

It could also have the additional check on the syntax whether any environment variable reference is not defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants