Linux support #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add paths and scripting for to support operation on linux. I wasn't able to get this to build, but it seems it's some issue with how I'm invoking pyinstaller. As a follow-on to this, I'll add a commit that moves a couple things around to allow the build to succeed which can be considered separately from this one.
I was having issues with building on linux. If my issue was actually that I am using pyinstaller wrong, then this commit shouldn't be accepted. This observes that the package was previous three files: - /b3denv.py, which just calls main() from b3denv.__main__ - /b3denv/__main__.py, which just calls main() from b3denv.__init__ - /b3denv/__init__.py, which defines all the logic (and incidentally also calls main()) That there's only one file that does more than call main() suggests that this should actually be a single-source project. This commit implements that.
|
Sorry I found an issue where a a plugin made with this doesn't work that I need to investigate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 thing, which can be accepted or rejected separately. The first adds Linux support and the second moves all code into a single source. The second is only necessary because I couldn't get a build that didn't give a
ModuleNotFoundErroron theb3denvpackage. This may be because of how I'm invokingpyinstaller, although I'm following the instructions in the README.Commit 1:
Add linux support
Add paths and scripting for to support operation on linux.
I wasn't able to get this to build, but it seems it's some issue with
how I'm invoking pyinstaller. As a follow-on to this, I'll add a commit
that moves a couple things around to allow the build to succeed which
can be considered separately from this one.
Commit 2:
Move the package into a single file
I was having issues with building on linux. If my issue was actually
that I am using pyinstaller wrong, then this commit shouldn't be
accepted.
This observes that the package was previous three files:
also calls main())
That there's only one file that does more than call main() suggests that
this should actually be a single-source project. This commit implements
that.