Compatibility with R 4.2 #473
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 14, 2022 10:36
class() returns all classes, not just the first one, resulting in somtimes evaluating multiple conditions.
VGAM's vfamily slot can be a chracter vector of length > 1, so we need to either take the first one or use aggregation functions like any/all when testing it inside if/else conditions.
It's unclear whether this will cause issues with the resulting output file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains the minimal changes I found necessary to install and run monocle 2 on R 4.2. Not all the below changes have been tested, since I'm not using all the corresponding features. Feel free to merge this if you're still interested in supporting monocle 2 on current R versions.
(I realize monocle 3 exists now, but we were already using monocle 2 for a project and switching mid-analysis was not practical.)