Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code readability #765

Merged
merged 2 commits into from
Jan 12, 2025
Merged

Conversation

McLaynV
Copy link
Contributor

@McLaynV McLaynV commented Jan 11, 2025

These changes aim to improve code readablility and maintainability.

My reason for renaming variable id -> tz_id is that it shadows a builtin id.

The others should be clear, but don't hesitate to ask for my reasons for individual changes.


📚 Documentation preview 📚: https://icalendar--765.org.readthedocs.build/

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12727773668

Details

  • 26 of 28 (92.86%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 96.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/icalendar/parser_tools.py 6 7 85.71%
src/icalendar/timezone/equivalent_timezone_ids.py 0 1 0.0%
Totals Coverage Status
Change from base Build 12617583933: -0.02%
Covered Lines: 4579
Relevant Lines: 4747

💛 - Coveralls

@niccokunzmann niccokunzmann merged commit 50d780e into collective:main Jan 12, 2025
18 of 19 checks passed
@niccokunzmann
Copy link
Member

Thanks!

@McLaynV McLaynV deleted the code-readability branch January 12, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants