Suggestion about way fixed bug #1080 #1081
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Confusion
reviewed
Oct 31, 2019
| :dir_mode => :normal, | ||
| :monitor => @monitor, | ||
| :ARGV => @args, | ||
| :pid_delimiter => options[:pid_delimiter]) do |*_args| |
There was a problem hiding this comment.
I think this isn't backwards compatible with older daemons versions, as the options parsing will raise an error when it encounters this unknown option. Ideally there would be a PR that doesn't pass this option to daemons versions that don't support it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I suggest adding an additional a
pid_delimiterattribute for the daemons gem. This attribute does not affect on compatibility with previous versionsdelayed_jobordemonsgems.I also can add additional tests regading this changes if the changes will make sense.
Fixes #1080