fix(PasswordFiled): fix password readonly visibility #2677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 363653c The changes in this PR will be included in the next version bump. This PR includes changesets to release 93 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@serge-dynamic is attempting to deploy a commit to the commercetools Team on Vercel. A member of the Team first needs to authorize it. |
|
Hello @serge-st I will be happy to help if you have any further questions 🙂 |
|
Hello @ddouglasz! Thanks for the prompt reply. I added changeset and updated the tests in my latest commit. |
ddouglasz
reviewed
Jan 2, 2024
| @@ -141,13 +141,27 @@ describe('when disabled', () => { | |||
| const { getByLabelText } = renderPasswordField({ isDisabled: true }); | |||
| expect(getByLabelText('PasswordField')).toBeDisabled(); | |||
| }); | |||
| it('should set the input type to password', () => { | |||
| const { container } = renderPasswordField({ isDisabled: true }); | |||
There was a problem hiding this comment.
We still need to give it some value, otherwise, the test will pass just all cases since we are testing a particular scenario:
- when there is value
- when readOnly and disabled
- when input type is text
Suggested change
| const { container } = renderPasswordField({ isDisabled: true }); | |
| const { getByLabelText } = renderPasswordField({ value: 'foo', isDisabled: true }); |
| @@ -141,13 +141,27 @@ describe('when disabled', () => { | |||
| const { getByLabelText } = renderPasswordField({ isDisabled: true }); | |||
| expect(getByLabelText('PasswordField')).toBeDisabled(); | |||
| }); | |||
| it('should set the input type to password', () => { | |||
| const { container } = renderPasswordField({ isDisabled: true }); | |||
| expect(container.querySelector('input')).toHaveAttribute( | |||
There was a problem hiding this comment.
Suggested change
| expect(container.querySelector('input')).toHaveAttribute( | |
| expect(getByLabelText('PasswordField')).toHaveAttribute( |
| }); | ||
|
|
||
| describe('when readOnly', () => { | ||
| it('should disable the input', () => { | ||
| const { getByLabelText } = renderPasswordField({ isReadOnly: true }); | ||
| expect(getByLabelText('PasswordField')).toHaveAttribute('readonly'); | ||
| }); | ||
| it('should set the input type to password', () => { | ||
| const { container } = renderPasswordField({ isReadOnly: true }); |
There was a problem hiding this comment.
Suggested change
| const { container } = renderPasswordField({ isReadOnly: true }); | |
| const { getByLabelText } = renderPasswordField({value: 'foo', isReadOnly: true }); |
| }); | ||
|
|
||
| describe('when readOnly', () => { | ||
| it('should disable the input', () => { | ||
| const { getByLabelText } = renderPasswordField({ isReadOnly: true }); | ||
| expect(getByLabelText('PasswordField')).toHaveAttribute('readonly'); | ||
| }); | ||
| it('should set the input type to password', () => { | ||
| const { container } = renderPasswordField({ isReadOnly: true }); | ||
| expect(container.querySelector('input')).toHaveAttribute( |
There was a problem hiding this comment.
Suggested change
| expect(container.querySelector('input')).toHaveAttribute( | |
| expect(getByLabelText('PasswordField')).toHaveAttribute( |
|
@ddouglasz Hello! Thank you for your patience. I followed your suggestion and made the test more uniform. I also covered:
about "when input type is text", since it is not possible to force input type via props, do you think it is needed to cover this as well, and how? |
Thank you for the changes. Honestly, I think these scenarios covered are enough. |
ddouglasz
reviewed
Jan 8, 2024
| 'password' | ||
| ); | ||
| }); | ||
| descrbe('when has value', () => { |
There was a problem hiding this comment.
Suggested change
| descrbe('when has value', () => { | |
| describe('when has value', () => { |
| 'password' | ||
| ); | ||
| }); | ||
| descrbe('when has value', () => { |
There was a problem hiding this comment.
Suggested change
| descrbe('when has value', () => { | |
| describe('when has value', () => { |
|
@ddouglasz my bad, I didn't setup the working environment correctly. Now I ran the format and lint scripts, checks should pass. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change can resolve #2676 by disabling password visibility every time the password field is set to readonly and or disabled