🐛 Exception handling

commonhaus · Dec 18, 2024 · 64c6b79 · 64c6b79
1 parent 2759176
commit 64c6b79
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/bot-github-core/src/main/java/org/commonhaus/automation/github/context/ActionType.java b/bot-github-core/src/main/java/org/commonhaus/automation/github/context/ActionType.java
@@ -19,6 +19,7 @@ public enum ActionType {
     submitted,
     synchronize,
     transferred,
+    unassigned,
     unanswered,
     unlabeled,
     unlocked,

diff --git a/...ub-core/src/main/java/org/commonhaus/automation/github/discovery/RepositoryDiscovery.java b/...ub-core/src/main/java/org/commonhaus/automation/github/discovery/RepositoryDiscovery.java
@@ -104,6 +104,9 @@ void discoverRepositories(@Observes StartupEvent ev) {
 
     void onEvent(@RawEvent GitHubEvent event, GitHub github, DynamicGraphQLClient graphQLClient) {
         ctx = ctxInstance.get();
+        if (event == null || event.getInstallationId() == null) {
+            return;
+        }
         ctx.updateConnections(event.getInstallationId(), github, graphQLClient);
     }
 

diff --git a/cf-admin-bot/src/main/java/org/commonhaus/automation/admin/github/TeamMemberSync.java b/cf-admin-bot/src/main/java/org/commonhaus/automation/admin/github/TeamMemberSync.java
@@ -389,6 +389,9 @@ void doSyncTeamMembers(TeamSourceConfig config, String fullTeamName, Set<String>
         Set<String> toRemove = new HashSet<>(currentLogins);
         toRemove.removeAll(sourceLogins);
 
+        Log.debugf("[%s] doSyncTeamMembers: %s; add %s; remove %s", qc.getLogId(),
+                fullTeamName, toAdd, toRemove);
+
         if (productionRun) {
             final Set<GHUser> validate = new HashSet<>();
             // Membership events will update the team cache; do nothing with the cache here.
@@ -410,8 +413,7 @@ void doSyncTeamMembers(TeamSourceConfig config, String fullTeamName, Set<String>
                             }
                         }
                     } catch (IOException e) {
-                        Log.warnf("[%s] doSyncTeamMembers: failed to find, add, or remove user %s", qc.getLogId(), login);
-                        ;
+                        Log.errorf(e, "[%s] doSyncTeamMembers: failed to find, add, or remove user %s", qc.getLogId(), login);
                     }
                 }
                 return null;