Fix passing of non-ASCII characters as command-line arguments

Should fix the issues described here: https://discourse.slicer.org/t/slicer-ignoring-command-line-path-with-accents/24569
commontk · Jul 2, 2024 · 9998a7d · 9998a7d
1 parent bdd082a
commit 9998a7d
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/Base/Testing/Cpp/ctkAppLauncherEnvironmentTest.cpp b/Base/Testing/Cpp/ctkAppLauncherEnvironmentTest.cpp
@@ -52,24 +52,24 @@ void ctkAppLauncherEnvironmentTester::cleanup()
   QStringList originalEnvKeys = ctkAppLauncherEnvironment::envKeys(this->OriginalEnv);
   foreach(const QString& varName, originalEnvKeys)
     {
-    qputenv(varName.toLatin1(), this->OriginalEnv.value(varName).toLatin1());
+    qputenv(varName.toLocal8Bit(), this->OriginalEnv.value(varName).toLocal8Bit());
     }
 }
 
 // ----------------------------------------------------------------------------
 void ctkAppLauncherEnvironmentTester::setEnv(const QString& name, const QString& value)
 {
-  qputenv(name.toLatin1(), value.toLatin1());
+  qputenv(name.toLocal8Bit(), value.toLocal8Bit());
   this->VariableNames.insert(name);
 }
 
 // ----------------------------------------------------------------------------
 void ctkAppLauncherEnvironmentTester::unsetEnv(const QString& name)
 {
 #if defined(_MSC_VER)
-  qputenv(name.toLatin1(), QString("").toLatin1());
+  qputenv(name.toLocal8Bit(), QString().toLocal8Bit());
 #else
-  unsetenv(name.toLatin1());
+  unsetenv(name.toLocal8Bit());
 #endif
 }
 

diff --git a/Base/ctkAppArguments.cpp b/Base/ctkAppArguments.cpp
@@ -58,7 +58,7 @@ void ctkChar2DArray::setValues(const QStringList& list)
     {
     QString item = d->List.at(index);
     d->Values[index] = new char[item.size() + 1];
-    qstrcpy(d->Values[index], item.toLatin1().data());
+    qstrcpy(d->Values[index], item.toLocal8Bit().data());
     }
 }
 

diff --git a/Base/ctkAppLauncherEnvironment.cpp b/Base/ctkAppLauncherEnvironment.cpp
@@ -166,9 +166,9 @@ void ctkAppLauncherEnvironment::updateCurrentEnvironment(const QProcessEnvironme
   foreach(const QString& varName, variablesToUnset)
     {
 #if defined(Q_OS_WIN32)
-    bool success = qputenv(varName.toLatin1(), QString("").toLatin1());
+    bool success = qputenv(varName.toLocal8Bit(), QString().toLocal8Bit());
 #else
-    bool success = unsetenv(varName.toLatin1()) == EXIT_SUCCESS;
+    bool success = unsetenv(varName.toLocal8Bit()) == EXIT_SUCCESS;
 #endif
     if (!success)
       {
@@ -180,7 +180,7 @@ void ctkAppLauncherEnvironment::updateCurrentEnvironment(const QProcessEnvironme
   foreach(const QString& varName, envKeys)
     {
     QString varValue = environment.value(varName);
-    bool success = qputenv(varName.toLatin1(), varValue.toLatin1());
+    bool success = qputenv(varName.toLocal8Bit(), varValue.toLocal8Bit());
     if (!success)
       {
       qWarning() << "Failed to set environment variable"

diff --git a/Base/ctkTest.h b/Base/ctkTest.h
@@ -97,8 +97,8 @@ static void mouseEvent(QTest::MouseAction action, QWidget *widget, Qt::MouseButt
     {
     static const char *mouseActionNames[] =
         { "MousePress", "MouseRelease", "MouseClick", "MouseDClick", "MouseMove" };
-    QString warning = QString::fromLatin1("Mouse event \"%1\" not accepted by receiving widget");
-    QTest::qWarn(warning.arg(QString::fromLatin1(mouseActionNames[static_cast<int>(action)])).toLatin1());
+    QString warning = QLatin1String("Mouse event \"%1\" not accepted by receiving widget");
+    QTest::qWarn(warning.arg(QLatin1String(mouseActionNames[static_cast<int>(action)])).toLocal8Bit());
     }
 }