-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH components #21
base: main
Are you sure you want to change the base?
GH components #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is still a draft, but I made some comments on the docs anyway... ;)
src/compas_rrc/ghpython/components/CompasRrc_ExecuteBatch/metadata.json
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_MoveToFrame/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_MoveToFrame/code.py
Outdated
Show resolved
Hide resolved
{ | ||
"name": "speed", | ||
"description": "Integer specifying TCP translational speed in mm/s.", | ||
"typeHintID": "int" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not float?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not float... ABB RAPID is an inflexible friend sometimes... :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but
if not speed or speed < 0.01:
add_warning('Speed must be greater or equal to 0.01 mm/s.')
…data.json Co-authored-by: beverlylytle <[email protected]>
Co-authored-by: beverlylytle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed a couple...
src/compas_rrc/ghpython/components/CompasRrc_MoveToFrame/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_MoveToFrame/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_WaitForFeedback/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_ExecuteBatch/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_ExecuteBatch/code.py
Outdated
Show resolved
Hide resolved
src/compas_rrc/ghpython/components/CompasRrc_ExecuteBatch/code.py
Outdated
Show resolved
Hide resolved
Co-authored-by: beverlylytle <[email protected]>
This is still a draft pull request, it adds a first batch of GH components but perhaps more importantly, sets up the project to add more in the coming days.
What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.rst
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).