Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comet support #87

Merged
merged 2 commits into from
Jul 10, 2024
Merged

comet support #87

merged 2 commits into from
Jul 10, 2024

Conversation

paretje
Copy link
Contributor

@paretje paretje commented Jul 10, 2024

Fix support for Comet generated pepXML and mzID files.

Closes: #86

paretje added 2 commits July 10, 2024 15:28
Comet's pepXML files contain spectrum queries without hits, we should
check and just skip those.

Closes: #86
@paretje paretje requested a review from RalfG July 10, 2024 14:20
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 64.73%. Comparing base (871bf43) to head (e711510).

Files Patch % Lines
psm_utils/io/mzid.py 0.00% 3 Missing ⚠️
psm_utils/io/pepxml.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   64.81%   64.73%   -0.08%     
==========================================
  Files          26       26              
  Lines        2498     2501       +3     
==========================================
  Hits         1619     1619              
- Misses        879      882       +3     
Flag Coverage Δ
unittests 64.73% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG merged commit 42f0fe3 into main Jul 10, 2024
5 of 7 checks passed
@RalfG RalfG deleted the hotfix/comet-support branch July 10, 2024 16:01
@RalfG RalfG added this to the v0.9.1 milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pepXML or mzIdentML from Comet
2 participants