Fix confusing method names and return values, refs #1408

src/Entity/Package.php

@@ -275,27 +275,37 @@ public function getVendor(): string
     }
 
     /**
-     * @return array<string> Vendor and package name
+     * @return array<string>|null Vendor and package name
      */
-    public function isGitHub(): array|false
+    public function getGitHubComponents(): array|null
     {
         if (Preg::isMatchStrictGroups('{^(?:git://|git@|https?://)github.com[:/]([^/]+)/(.+?)(?:\.git|/)?$}i', $this->getRepository(), $match)) {
             return $match;
         }
 
-        return false;
+        return null;
     }
 
     /**
-     * @return array<string> Vendor and package name
+     * @return array<string>|null Vendor and package name
      */
-    public function isGitLab(): array|false
+    public function getGitLabComponents(): array|null
     {
         if (Preg::isMatchStrictGroups('{^(?:git://|git@|https?://)gitlab.com[:/]([^/]+)/(.+?)(?:\.git|/)?$}i', $this->getRepository(), $match)) {
             return $match;
         }
 
-        return false;
+        return null;
+    }
+
+    public function isGitHub(): bool
+    {
+        return (bool) $this->isGitHub();
+    }
+
+    public function isGitLab(): bool
+    {
+        return (bool) $this->isGitLab();
     }
 
     /**
@@ -362,7 +372,7 @@ public function getGitHubStarsUrl(): string|null
     {
         if ($this->isGitHub()) {
             return $this->getBrowsableRepository() . '/stargazers';
-        } 
+        }
         if ($this->isGitLab()) {
             return $this->getBrowsableRepository() . '/-/starrers';
         }

src/Package/Updater.php

@@ -242,9 +242,9 @@ public function update(IOInterface $io, Config $config, Package $package, VcsRep
             );
         }
 
-        if ($match = $package->isGitHub()) {
+        if (null !== ($match = $package->getGitHubComponents())) {
             $this->updateGitHubInfo($httpDownloader, $package, $match[1], $match[2], $driver);
-        } elseif ($match = $package->isGitLab()) {
+        } elseif (null !== ($match = $package->getGitLabComponents())) {
             $this->updateGitLabInfo($httpDownloader, $io, $package, $match[1], $match[2], $driver);
         } else {
             $this->updateReadme($io, $package, $driver);