refactor: represent requires in resources #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: a compatibility requirement needs to clearly be matched to resources, at least the subset that goes into a match in the graph. Solution: refactor the jobspec so top level resources can have slots that have nested "requires" at the level they are needed. I also found a way to remove the "slot" idea and just replace it with the idea of asking for replicas of a particular place in the resource request. Note that the implementation is not updated yet, just the spec, and I am opening a PR so I can stare at it. Signed-off-by: vsoch <[email protected]>
Problem: requires needs to be grouped with schedule-able groups. Solution: simplify the jobspec to allow that. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
These are for cluster state that is desired. We likely will want to move these into schedulable units. Signed-off-by: vsoch <[email protected]>
Signed-off-by: vsoch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: a compatibility requirement needs to clearly be matched to resources, at least the subset that goes into a match in the graph.
Solution: refactor the jobspec so top level resources can have slots that have nested "requires" at the level they are needed. I also found a way to remove the "slot" idea and just replace it with the idea of asking for replicas of a particular place in the resource request. Note that the implementation is not updated yet, just the spec, and I am opening a PR so I can stare at it.