Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add command line flags for host profile. #471

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add command line flags for host profile. #471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f47dc6b
Add command line flags for host profile.
TobiSchluter Jan 18, 2023
baeac89
Add POFILE_HOST to multiValueArgs
TobiSchluter Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion conan.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,10 @@ function(conan_cmake_settings result)
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET)
set(_SETTINGS ${_SETTINGS} -pr:b=${ARG})
endforeach()
foreach(ARG ${ARGUMENTS_PROFILE_HOST})
conan_check(VERSION 1.24.0 REQUIRED DETECT_QUIET)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hardcoded check repeated for every profile seems wrong. It seems the previous one for PROFILE_BUILD was a bit legacy and dirty, it shouldn't be done that way.

set(_SETTINGS ${_SETTINGS} -pr:h=${ARG})
endforeach()

if(NOT _SETTINGS OR ARGUMENTS_PROFILE_AUTO STREQUAL "ALL")
set(ARGUMENTS_PROFILE_AUTO arch build_type compiler compiler.version
Expand Down Expand Up @@ -480,7 +484,7 @@ macro(conan_parse_arguments)
set(oneValueArgs CONANFILE ARCH BUILD_TYPE INSTALL_FOLDER OUTPUT_FOLDER CONAN_COMMAND)
set(multiValueArgs DEBUG_PROFILE RELEASE_PROFILE RELWITHDEBINFO_PROFILE MINSIZEREL_PROFILE
PROFILE REQUIRES OPTIONS IMPORTS SETTINGS BUILD ENV GENERATORS PROFILE_AUTO
INSTALL_ARGS CONFIGURATION_TYPES PROFILE_BUILD BUILD_REQUIRES)
INSTALL_ARGS CONFIGURATION_TYPES PROFILE_BUILD PROFILE_HOST BUILD_REQUIRES)
cmake_parse_arguments(ARGUMENTS "${options}" "${oneValueArgs}" "${multiValueArgs}" ${ARGN})
endmacro()

Expand Down