Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try to upgrade urllib3, first to 2.0 #17655

Open
wants to merge 2 commits into
base: develop2
Choose a base branch
from
Open

try to upgrade urllib3, first to 2.0 #17655

wants to merge 2 commits into from

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Jan 28, 2025 •
edited by AbrilRBS
Loading

Changelog: Feature: Upgrade dependency urllib3 to 2.0.
Docs: Omit

Related to #13948

Note that this would not affect Python 3.6 users, which won't get the new incompatible versions

@memsharded memsharded mentioned this pull request Jan 30, 2025
Merged
@memsharded memsharded marked this pull request as ready for review January 31, 2025 13:25
@memsharded memsharded added this to the 2.13.0 milestone Jan 31, 2025
@memsharded memsharded requested a review from AbrilRBS January 31, 2025 13:26
AbrilRBS
AbrilRBS approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@AbrilRBS AbrilRBS left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get no urllib warnings when running the tests are suggested in https://urllib3.readthedocs.io/en/stable/v2-migration-guide.html#migrating-as-a-package-maintainer for 3.12

@AbrilRBS AbrilRBS mentioned this pull request Feb 3, 2025
Merged
@memsharded
Copy link
Member Author

Fantastic, thanks very much @AbrilRBS

I think this is ready then @czoido and we can try the upgrade for next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbrilRBS AbrilRBS AbrilRBS approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@memsharded @czoido @AbrilRBS