Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[incubating][CMakeDeps] Adding more CMake paths #17668

Merged
merged 6 commits into from
Feb 3, 2025
Merged

[incubating][CMakeDeps] Adding more CMake paths #17668

merged 6 commits into from
Feb 3, 2025

Conversation

franramirez688
Copy link
Contributor

Changelog: Feature: Added CMAKE_LIBRARY_PATH to conan_cmakedeps_paths.cmake (new CMakeDeps)
Changelog: Feature: Added CMAKE_INCLUDE_PATH to conan_cmakedeps_paths.cmake (new CMakeDeps)
Docs: omit

@franramirez688 franramirez688 added this to the 2.13.0 milestone Jan 30, 2025
memsharded
memsharded reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good.

I think I'd try to add a fully functional test (or add extra checks to existing tests, to avoid adding more slow tests) that validates find_file() and find_library() with actual built targets.

conan/tools/cmake/cmakedeps2/cmakedeps.py Outdated Show resolved Hide resolved
@franramirez688 franramirez688 merged commit 31d3201 into conan-io:develop2 Feb 3, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@franramirez688 @memsharded