Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add add_tests and add_build on cycloneDX tool #17695

Merged

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Feb 4, 2025

Changelog: Feature: Add add_tests and add_build feature on cycloneDX tool
Docs: https://github.com/conan-io/docs/pull/XXXX

Close: #17687

Copy link

@sbouchexbellomie-Philips sbouchexbellomie-Philips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me

@memsharded memsharded added this to the 2.13.0 milestone Feb 4, 2025
@ErniGH ErniGH changed the title Add add_tests on cycloneDX tool Add add_tests and add_build on cycloneDX tool Feb 4, 2025
@ErniGH
Copy link
Contributor Author

ErniGH commented Feb 4, 2025

Hello @sbouchexbellomie-Philips , we have also added the parameter add_build to allow for the separation of tool_requires and other build packages. We think it would be useful to have the option to omit this by default.
The idea is to keep by default just the dependencies of the software.

What do you think? 🤔

@memsharded memsharded merged commit 000fdee into conan-io:develop2 Feb 6, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] cyclonedx sbom generation should offer an option to exclude "test" dependencies
4 participants