-
-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish openblas variants on windows; remove blis workarounds #130
Conversation
This reverts commit 51ee509.
otherwise 24.9 gets pulled in for some reason
…onda-forge-pinning 2024.12.18.11.57.07
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/13009183272. Examine the logs at this URL for more detail. |
49259c1
to
4075fe2
Compare
@h-vetinari, as per my findings in conda/conda-build#5571, |
Amazing work! 🤩 Thank you so much! 🙏 |
39d8013
to
0a93b4f
Compare
This reverts commit 57bdf6b.
…nda-forge-pinning 2025.01.24.17.08.54
…` for blis" This reverts commit 4dbd015.
@conda-forge/blas, thanks to the magic touch of @jaimergp this is now ready, PTAL! :) It does a few long-planned things:
|
@isuruf, I'd appreciate your review on this change |
recipe/meta.yaml
Outdated
- test -f $PREFIX/lib/liblapacke.so # [linux] | ||
- test -f $PREFIX/lib/liblapacke.so.{{ version_major }} # [linux] | ||
- test -f $PREFIX/lib/liblapacke.dylib # [osx] | ||
- test -f $PREFIX/lib/liblapacke.{{ version_major }}.dylib # [osx] | ||
- if not exist %LIBRARY_BIN%/liblapacke.dll exit 1 # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's keep these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I've kept these, but in blas-devel
(which blas
now wraps)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine, but it's better to have the tests here in addition to the ones in blas-devel
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll reinstate, but I don't understand... If the files are actually contained in blas-devel
, and blas
is a pure wrapper-package with no content, tests on the wrapper are redundant with the tests for the package being wrapped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment
recipe/meta.yaml
Outdated
- test -f $PREFIX/lib/liblapacke.so # [linux] | ||
- test -f $PREFIX/lib/liblapacke.so.{{ version_major }} # [linux] | ||
- test -f $PREFIX/lib/liblapacke.dylib # [osx] | ||
- test -f $PREFIX/lib/liblapacke.{{ version_major }}.dylib # [osx] | ||
- if not exist %LIBRARY_BIN%/liblapacke.dll exit 1 # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review! I've kept these, but in blas-devel
(which blas
now wraps)
This combines two PRs, where one doesn't work (or make much sense) without the other.
Mainly I wanted to do #129, which is a follow-up to #126, which however runs into a bunch of conda-build bugs (conda/conda-build#5571, conda/conda-build#5572).
The other (#115) is for removing a very long-standing workaround for an unspecified conda-build bug that goes back forever (f9b54a0), but which doesn't seem to trigger anymore with 24.11.
The hope is that #129 + #115 passes, where #129 alone is currently stuck
Closes #129
Closes #115