Set EOL format across script & YAMLs #2236
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
approved these changes
Jan 31, 2025
h-vetinari
reviewed
Jan 31, 2025
Comment on lines
-7
to
+5
| bld.bat text eol=crlf | ||
| *.bat text eol=crlf |
There was a problem hiding this comment.
I'm wondering if this is really necessary actually. Given that all windows build scripts that weren't named bld.bat (e.g. in multi-output recipes) seem to run fine so far, I wonder what the benefit is of actually checking in crlf line endings?
On windows, stuff will be checked out by default with crlf anyway; and I'm not sure if anyone is trying to run windows scripts on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentrypython conda_smithy/schema.py)