Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Add tegra arm_variant_type #32

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

traversaro
Copy link

@traversaro traversaro commented Dec 11, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@traversaro traversaro requested a review from a team as a code owner December 11, 2024 20:30
@traversaro
Copy link
Author

@conda-forge-admin, please rerender

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 11, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). Your recipe may not receive automatic updates and/or may not be compatible with conda-forge's infrastructure. Please check the logs for more information and ensure your recipe can be parsed.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12284424160. Examine the logs at this URL for more detail.

@jakirkham
Copy link
Member

Thanks @traversaro ! 🙏

Appreciate you letting us know this is of interest to you and investigating next steps.

Instead of opening a bunch of PRs here, could I please suggest raising a new cuda-feedstock issue?

Then we can discuss and plan the broader rollout with the @conda-forge/cuda packaging team

This will also save you from needing to create ~50 PR 😉

@traversaro
Copy link
Author

Sure! I was not planning to open ~50 PRS, just the minimum required to run pytorch on Jetson Orin (hence the PRs marked as draft) to get a clear idea of the landscape, and with that info be able to open an informed issue. Sorry for the noise, I should probably have avoid the PRs (to be honest I just opened them as it was the fastest way to quickly run CI on my modifications).

@jakirkham
Copy link
Member

Not at all

It is a useful signal that this is an important feature we should start prioritizing. We likely wouldn't have known otherwise

Just trying to help focus our efforts for maximum effectiveness 🙂

When you open that issue, please link it in any of the PRs you already have open so we can tie the discussions together

@traversaro
Copy link
Author

Instead of opening a bunch of PRs here, could I please suggest raising a new cuda-feedstock issue?

Done: conda-forge/cuda-feedstock#57 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants