Migrate hdf5 version

[hmaarrfk]

Blocked on: #35

Checklist

• Used a personal fork of the feedstock to propose changes
• Bumped the build number (if the version is unchanged)
• Reset the build number to 0 (if the version changed)
• Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• Ensured the license file is being packaged.

[conda-forge-linter]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

• License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

[xylar]

A new version will be needed for #34, #35 and then this, and there's no indication of when that might happen:
Unidata/netcdf-cxx4#106

[hmaarrfk]

@conda-forge-admin please rerender

[hmaarrfk]

With enough patching, anything is possible!

[hmaarrfk]

@xylar for some reason osx find HDF5 but then fails at defining the variables.

Maybe we can help CMake find HDF5 somehow?

[xylar]

@hmaarrfk, sorry, I really don't have much expertise at all in Cmake. I'm not sure I'm going to be much help here. Seems pretty frustrating!

[hmaarrfk]

The "not enough" argument error is a red herring. The real error is that FindHDF5 does not set the variables correctly

[xylar]

@hmaarrfk, you got it! At least it looks that way!

[xylar]

@hmaarrfk, thanks a lot for adding yourself as a maintainer. That's very much appreciated.

[kmuehlbauer]

@hmaarrfk Great sleuthing!

[hmaarrfk]

Merging this will basically close out the HDF5 migration. It doesn't seem like there is much else that needs to be moved over.

[xylar]

Looks good to me!

[xylar]

@ocefpaf and @kmuehlbauer, let me know if you have any concerns. I'll merge this unless I hear something soon (by tomorrow).

[ocefpaf]

👍

[ocefpaf]

@ocefpaf and @kmuehlbauer, let me know if you have any concerns. I'll merge this unless I hear something soon (by tomorrow).

LGTM! Merge away!!

Thanks @hmaarrfk!