Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maint] drop pydantic pin #20

Merged
merged 2 commits into from
Mar 9, 2024

Conversation

psobolewskiPhD
Copy link
Member

@psobolewskiPhD psobolewskiPhD commented Mar 9, 2024

Closes napari/npe2#343
In napari/npe2#321 the pydantic < 2 pin was dropped from npe2 but it was missed here, so the conda-forge package still requires pydantic 1.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@psobolewskiPhD
Copy link
Member Author

@conda-forge-admin, please rerender

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@psobolewskiPhD
Copy link
Member Author

psobolewskiPhD commented Mar 9, 2024

We need to fix this for the future, but for now I think we want to patch https://github.com/conda-forge/conda-forge-repodata-patches-feedstock
to lift the pin for 0.7.3 & 0.7.4
So then in principle don't need this PR at the moment?
CC: @jaimergp any advice?

Edit: I went for it: conda-forge/conda-forge-repodata-patches-feedstock#678

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Mar 9, 2024

Indeed it seems to have been dropped.

Thanks: https://github.com/napari/npe2/blob/v0.7.4/pyproject.toml#L38

@hmaarrfk hmaarrfk merged commit cbd3334 into conda-forge:main Mar 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong pydantic version pin on conda-forge?
2 participants