Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Thunderstorm Event Reconnaissance (THUNER) package #28762

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

eshort0401
Copy link

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found some lint.

Here's what I've got...

For recipes/thuner/meta.yaml:

  • ❌ The recipe must have a build/number section.
  • ❌ There are too few lines. There should be one empty line at the end of the file.
  • ❌ license_file entry is missing, but is required.
  • requirements: host: python=3.10 must contain a space between the name and the pin, i.e. python =3.10
  • requirements: run: python=3.10 must contain a space between the name and the pin, i.e. python =3.10
  • requirements: run: numpy=2.0 must contain a space between the name and the pin, i.e. numpy =2.0
  • requirements: run: numba=0.60 must contain a space between the name and the pin, i.e. numba =0.60
  • requirements: run: scipy=1.14 must contain a space between the name and the pin, i.e. scipy =1.14
  • requirements: run: scikit-image=0.24 must contain a space between the name and the pin, i.e. scikit-image =0.24
  • requirements: run: pandas=2.2 must contain a space between the name and the pin, i.e. pandas =2.2
  • requirements: run: matplotlib=3.9 must contain a space between the name and the pin, i.e. matplotlib =3.9
  • requirements: run: xarray=2024.9 must contain a space between the name and the pin, i.e. xarray =2024.9
  • requirements: run: cartopy=0.24 must contain a space between the name and the pin, i.e. cartopy =0.24
  • requirements: run: typing_extensions=4.12 must contain a space between the name and the pin, i.e. typing_extensions =4.12
  • requirements: run: ipykernel=6.29 must contain a space between the name and the pin, i.e. ipykernel =6.29
  • requirements: run: netcdf4=1.7 must contain a space between the name and the pin, i.e. netcdf4 =1.7
  • requirements: run: h5netcdf=1.4 must contain a space between the name and the pin, i.e. h5netcdf =1.4
  • requirements: run: requests=2.32 must contain a space between the name and the pin, i.e. requests =2.32
  • requirements: run: arm_pyart=1.19 must contain a space between the name and the pin, i.e. arm_pyart =1.19
  • requirements: run: tqdm=4.66 must contain a space between the name and the pin, i.e. tqdm =4.66
  • requirements: run: cdsapi=0.7 must contain a space between the name and the pin, i.e. cdsapi =0.7
  • requirements: run: xesmf=0.8 must contain a space between the name and the pin, i.e. xesmf =0.8
  • requirements: run: opencv=4.10 must contain a space between the name and the pin, i.e. opencv =4.10
  • requirements: run: nco=5.2 must contain a space between the name and the pin, i.e. nco =5.2
  • requirements: run: awscli=1.35 must contain a space between the name and the pin, i.e. awscli =1.35
  • requirements: run: pytables=3.10 must contain a space between the name and the pin, i.e. pytables =3.10
  • requirements: run: pydantic=2.9 must contain a space between the name and the pin, i.e. pydantic =2.9
  • requirements: run: zarr=2.18 must contain a space between the name and the pin, i.e. zarr =2.18
  • requirements: run: windrose=1.9 must contain a space between the name and the pin, i.e. windrose =1.9
  • requirements: run: pydot=3.0 must contain a space between the name and the pin, i.e. pydot =3.0
  • requirements: run: metpy=1.6 must contain a space between the name and the pin, i.e. metpy =1.6
  • ❌ noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

For recipes/thuner/meta.yaml:

  • ℹ️ No valid build backend found for Python recipe for package thuner using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).
  • ℹ️ PyPI default URL is now pypi.org, and not pypi.io. You may want to update the default source url.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12626605149. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/thuner/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.
  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12626849115. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found some lint.

Here's what I've got...

For recipes/thuner/meta.yaml:

  • requirements: run: numpy=2.0 must contain a space between the name and the pin, i.e. numpy =2.0
  • requirements: run: numba=0.60 must contain a space between the name and the pin, i.e. numba =0.60
  • requirements: run: scipy=1.14 must contain a space between the name and the pin, i.e. scipy =1.14
  • requirements: run: scikit-image=0.24 must contain a space between the name and the pin, i.e. scikit-image =0.24
  • requirements: run: pandas=2.2 must contain a space between the name and the pin, i.e. pandas =2.2
  • requirements: run: matplotlib=3.9 must contain a space between the name and the pin, i.e. matplotlib =3.9
  • requirements: run: xarray=2024.9 must contain a space between the name and the pin, i.e. xarray =2024.9
  • requirements: run: cartopy=0.24 must contain a space between the name and the pin, i.e. cartopy =0.24
  • requirements: run: typing_extensions=4.12 must contain a space between the name and the pin, i.e. typing_extensions =4.12
  • requirements: run: pre-commit=4.0 must contain a space between the name and the pin, i.e. pre-commit =4.0
  • requirements: run: black=24.10 must contain a space between the name and the pin, i.e. black =24.10
  • requirements: run: pytest=8.3 must contain a space between the name and the pin, i.e. pytest =8.3
  • requirements: run: pytest-cov=5.0 must contain a space between the name and the pin, i.e. pytest-cov =5.0
  • requirements: run: codecov=2.1 must contain a space between the name and the pin, i.e. codecov =2.1
  • requirements: run: ipykernel=6.29 must contain a space between the name and the pin, i.e. ipykernel =6.29
  • requirements: run: netcdf4=1.7 must contain a space between the name and the pin, i.e. netcdf4 =1.7
  • requirements: run: h5netcdf=1.4 must contain a space between the name and the pin, i.e. h5netcdf =1.4
  • requirements: run: requests=2.32 must contain a space between the name and the pin, i.e. requests =2.32
  • requirements: run: arm_pyart=1.19 must contain a space between the name and the pin, i.e. arm_pyart =1.19
  • requirements: run: tqdm=4.66 must contain a space between the name and the pin, i.e. tqdm =4.66
  • requirements: run: cdsapi=0.7 must contain a space between the name and the pin, i.e. cdsapi =0.7
  • requirements: run: xesmf=0.8 must contain a space between the name and the pin, i.e. xesmf =0.8
  • requirements: run: opencv=4.10 must contain a space between the name and the pin, i.e. opencv =4.10
  • requirements: run: nco=5.2 must contain a space between the name and the pin, i.e. nco =5.2
  • requirements: run: awscli=1.35 must contain a space between the name and the pin, i.e. awscli =1.35
  • requirements: run: pytables=3.10 must contain a space between the name and the pin, i.e. pytables =3.10
  • requirements: run: memory_profiler=0.61 must contain a space between the name and the pin, i.e. memory_profiler =0.61
  • requirements: run: psutil=6.0 must contain a space between the name and the pin, i.e. psutil =6.0
  • requirements: run: pydantic=2.9 must contain a space between the name and the pin, i.e. pydantic =2.9
  • requirements: run: zarr=2.18 must contain a space between the name and the pin, i.e. zarr =2.18
  • requirements: run: windrose=1.9 must contain a space between the name and the pin, i.e. windrose =1.9
  • requirements: run: pydot=3.0 must contain a space between the name and the pin, i.e. pydot =3.0
  • requirements: run: metpy=1.6 must contain a space between the name and the pin, i.e. metpy =1.6

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12627980105. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/thuner/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12628022391. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found some lint.

Here's what I've got...

For recipes/thuner/meta.yaml:

  • ❌ Invalid noarch value python 9999. Should be one of python, generic.

For recipes/thuner/meta.yaml:

  • ℹ️ Recipes should usually depend on matplotlib-base as opposed to matplotlib so that runtime environments do not require large packages like qt.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12628222575. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/thuner/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12630918123. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/thuner/meta.yaml) and found it was in an excellent condition.

@eshort0401 eshort0401 marked this pull request as ready for review January 7, 2025 02:55
@eshort0401
Copy link
Author

@conda-forge/help-python thuner package ready for review!

@eshort0401
Copy link
Author

Confirming that @eshort0401 accepts to be listed in the maintainers list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants