Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add easysnowdata package #28781

Merged
merged 8 commits into from
Jan 15, 2025
Merged

add easysnowdata package #28781

merged 8 commits into from
Jan 15, 2025

Conversation

egagli
Copy link
Contributor

@egagli egagli commented Jan 7, 2025

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

github-actions bot commented Jan 7, 2025

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Jan 7, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/easysnowdata/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/easysnowdata/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12729746208. Examine the logs at this URL for more detail.

sha256: 41de137a200a0732370772f66c12ca19f2dac97097d3e4748c23497680cf964b

build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please look at the docs for noarch: python recipes:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

specifically the use of {{ python_min }}. This will fix up your linting errors.

- planetary-computer
- odc-stac
- xee
- bs4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying changing bs4 to beautifulsoup4. I'm not sure, but I'm hoping this fixes the pip check errors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that worked, thank you!

@egagli
Copy link
Contributor Author

egagli commented Jan 12, 2025

@conda-forge-admin
@conda-forge/help-python, ready for review, thank you!

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/easysnowdata/meta.yaml) and found it was in an excellent condition.

@synapticarbors
Copy link
Member

So it looks like it's failing because the python_min is 3.9, but the package uses syntax like:

def get_forest_cover_fraction(bbox_input: gpd.GeoDataFrame | tuple | shapely.geometry.base.BaseGeometry | None = None, mask_nodata: bool = False,

where the pipe | for union is only supported in python 3.10 and higher. This means that the upstream python_requires in the pyproject.toml is wrong and you you would need to add {% set python_min = "3.10" %} at the top of the recipe below the version jinja.

@egagli
Copy link
Contributor Author

egagli commented Jan 15, 2025

@synapticarbors Thank you so much for your help! I think we're all set now?

@synapticarbors synapticarbors merged commit e6148ae into conda-forge:main Jan 15, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants