Windows: Disable OpenMP #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OpenMP implementation of most of the Conda-Forge software stack is using MSVC's OpenMP runtime (limited to OpenMP 2.0). This is also what is used in blosc in our dependencies. When we compile WarpX, we need a newer OpenMP (4.0+), which is why we compiled with LLVM. Unfortunately, the LLVM OpenMP runtime and MSVC runtime cannot be loaded at the same time and thus crash if we perform I/O operations. For now, we just disable OpenMP for WarpX builds. In the future, Microsoft might upgrade their OpenMP runtime: https://devblogs.microsoft.com/cppblog/improved-openmp-support-for-cpp-in-visual-studio/
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
…a-forge-pinning 2021.10.12.12.38.27
|
MSVC build: So we keep using LLVM (but w/o OpenMP). |
|
@conda-forge-admin, please rerender |
|
Hi! This is the friendly automated conda-forge-webservice. |
ax3l
added a commit
to ax3l/warpx-feedstock
that referenced
this pull request
Oct 29, 2021
Forgot to redeclare the dependency in conda-forge#31 (see conda-forge#29).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenMP implementation of most of the Conda-Forge software stack is using MSVC's OpenMP runtime (limited to OpenMP 2.0). This is also what is used in blosc in our dependencies.
When we compile WarpX, we need a newer OpenMP (4.0+), which is why we compiled with LLVM. Unfortunately, the LLVM OpenMP runtime and MSVC runtime cannot be loaded at the same time and thus crash if we perform I/O operations (ref.: ECP-WarpX/WarpX#1776).
For now, we just disable OpenMP for WarpX builds. In the future, Microsoft might upgrade their OpenMP runtime:
https://devblogs.microsoft.com/cppblog/improved-openmp-support-for-cpp-in-visual-studio/
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)