Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set patchelf<0.18 #5607

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Set patchelf<0.18 #5607

wants to merge 3 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Jan 31, 2025

Description

Copy patchelf<0.18 from conda-forge.

Xref conda-forge/conda-build-feedstock#243
Xref #4881

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@kenodegard kenodegard requested a review from a team as a code owner January 31, 2025 21:40
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jan 31, 2025
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #5607 will not alter performance

Comparing patchelf-0.18 (d4ecf0f) with main (b18f4c3)

Summary

✅ 5 untouched benchmarks

Copy link
Contributor

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a news item?

jakirkham
jakirkham previously approved these changes Feb 1, 2025
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ken! 🙏

Had a suggestion on the comment formatting. Otherwise looks good

recipe/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: jakirkham <[email protected]>
@beckermr beckermr enabled auto-merge (squash) February 1, 2025 10:49
@tkelman
Copy link
Contributor

tkelman commented Feb 1, 2025

There's already been a likely fix merged to master of patchelf (NixOS/patchelf#566), but who knows when they'll tag an 0.18.1 or 0.19 release including it. It'd be wishful thinking and a bit unconventional but hopefully this constraint will end up being relax-able to !=0.18 down the line

@beckermr
Copy link
Contributor

beckermr commented Feb 1, 2025

Test failures appear persistent. We'll need to investigate those separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

6 participants