Merge pull request #2 from cons-tan-tan/feature

FIx misc
cons-tan-tan · Mar 26, 2024 · ba39dee · ba39dee
2 parents b7eddd1 + 6f0a774
commit ba39dee
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/src/main/java/bqlogging/BetterQuestLogging.java b/src/main/java/bqlogging/BetterQuestLogging.java
@@ -8,7 +8,6 @@
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 
-import betterquesting.api.api.QuestingAPI;
 import betterquesting.api.events.QuestEvent;
 import betterquesting.api.properties.NativeProps;
 import betterquesting.api.questing.IQuest;
@@ -24,7 +23,8 @@
     version = Tags.VERSION,
     name = "BetterQuestLogging",
     acceptedMinecraftVersions = "[1.7.10]",
-    dependencies = "required-after:betterquesting")
+    dependencies = "required-after:betterquesting",
+    acceptableRemoteVersions = "*")
 public class BetterQuestLogging {
 
     public static final String MODID = "bqlogging";
@@ -56,19 +56,17 @@ public void onQuestEvent(QuestEvent event) {
             return;
         }
 
-        String playerName = QuestingAPI.getPlayer(event.getPlayerID())
-            .getDisplayName();
         questIds.forEach(uuid -> {
             IQuest quest = QuestDatabase.INSTANCE.get(uuid);
             if (quest == null) {
                 LOG.error(String.format("Quest with ID %s does not exist", uuid));
                 return;
+            } else if (quest.getProperty(NativeProps.SILENT)) {
+                return;
             }
             LOG.info(
                 String.format(
-                    "%s completed the quest %s: %s",
-                    playerName,
-                    quest.getProperty(NativeProps.GLOBAL) ? "[GLOBAL]" : "",
+                    "Quest Completed: %s",
                     QuestTranslation.translateQuestName(uuid, quest)
                         .replaceAll("§.", "")));
         });