Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes Axelar Token Contracts Upgradeable #841

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Makes Axelar Token Contracts Upgradeable #841

wants to merge 6 commits into from

Conversation

snissn
Copy link
Contributor

@snissn snissn commented Mar 25, 2024 •
edited by raulk
Loading

Closes #993.

  • IpcTokenHandler.sol

    • Move constructor to initialize
    • Inherit from Initializable

  • InterchainTokenExecutable.sol

    • Build an upgradable form of this in the axelar-token folder

  • IpcTokenSender.sol

    • Move constructor to initialize()
    • Inherit from Initializable

  • sdk/IpcContract.sol

    • Move constructor of IpcExchange to initialize()
    • Inherit from onlyInitializing
    • Update ownable and reentry guard imports and initialize them

  • Update Deploy script

    • Use correct initCall format handler
    • Use correct initCall format sender
    • Deploy sender & handler implementation
    • token_sender_implementation and token_handler_implementation in addresses/out.json

  • Upgrade script

    • works properly

This change is Reviewable

@snissn snissn requested a review from raulk March 25, 2024 22:35
@linear Linear
Copy link

linear bot commented Mar 25, 2024

ENG-739 Make axelar-token contract upgradable

snissn added 2 commits April 5, 2024 15:14
@snissn
merge
de9aa33
@snissn
Axelar token Upgrade - fixes related to reinitialize and improved mak…
b5b6a1a 
…efile (#868)

- add example v2 implementation with updated deployment scripts + Makefile
- remove reinitialize from initial implementation contract
@snissn
Copy link
Contributor Author

snissn commented Apr 6, 2024

Latest fixes and improvements to move reinitialized and update the makefile and deployment scripting was merged in here #868

@jsoares
Copy link
Contributor

jsoares commented Apr 19, 2024

@raulk could you please review or delegate to someone else? 🙏

@maciejwitowski maciejwitowski mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulk raulk Awaiting requested review from raulk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
IPC Core Development
Status: Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make axelar-token contract upgradable
2 participants
@snissn @jsoares