added the ttrpc stress utility #179
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawahars
force-pushed
the
ttrpc-stress
branch
2 times, most recently
from
1795e7e to
76b554f
Compare
This change adds a stress utility which can be used for stress testing the ttrpc connection. This tool represents a simple client-server interaction where the client sends continuous requests to the server, and the server responds with the same data, allowing for testing of concurrent request handling and response verification. This tool is adapted from https://github.com/kevpar/ttrpcstress.git which was written by Kevin Parsons. Signed-off-by: Harsh Rawat <[email protected]>
rawahars
force-pushed
the
ttrpc-stress
branch
from
76b554f to
b34c64f
Compare
|
Hi @rawahars, thanks for working on this. I see right now you are checking in a While this is a good starting point for the work, I think we need to have a plan for how this will be integrated into tests (and ultimately, run in CI) in this repo. This may change the approach taken in this PR. For instance, it may be better to check in tests using the stress code, rather than a binary that must be built. I would recommend you outline first, here or in an issue, the overall approach to introducing CI testing for TTRPC deadlock issues. Then review can proceed from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request introduces a new utility,
ttrpc-stress, designed to stress-test TTRPC connections. This tool represents a simple client-server interaction where the client sends continuous requests to the server, and the server responds with the same data, allowing for testing of concurrent request handling and response verification.The stress utility was primarily developed to simulate deadlock issues between the client and server, particularly when different versions are used and is adapted from https://github.com/kevpar/ttrpcstress which was written by
Kevin Parsons(https://github.com/kevpar).Version Compatibility Testing
Known Issues in TTRPC Versions
Please refer to #72 for more information about the deadlock bug.
v1.1.0v1.2.0v1.2.4The goal is to test the
current versionof TTRPC, which is used to buildttrpc-stress, against the following older versions in both server and client scenarios:v1.0.2v1.1.0v1.2.0v1.2.4latestFuture Work
v1.0.2,v1.1.0,v1.2.0, andv1.2.4.mainwherein we will pull the older tags with tool as above, and then run the stress test matrix for server and client scenarios.