Update c/image and update tests #5932
Conversation
go.mod
Outdated
|
|
||
| require ( | ||
| github.com/containerd/platforms v1.0.0-rc.1 | ||
| github.com/containernetworking/cni v1.2.3 | ||
| github.com/containers/common v0.61.1 | ||
| github.com/containers/image/v5 v5.33.1 | ||
| github.com/containers/common v0.61.0 |
There was a problem hiding this comment.
This is downgrading c/common, I would suggest you just bump it to main
There was a problem hiding this comment.
Oops, thanks for noticing that.
This is almost certainly because the latest c/image release is from a (comparatively) fairly old stable branch, and Go doesn’t know that main is ahead.
containers/image#2691 should help, then I’ll update this PR. Marking as draft in the meantime.
To do this, update expected errors when pulling encrypted images containers/image#2646 will track actually returning a meaningful error instead of these internal details. Signed-off-by: Miloslav Trmač <[email protected]>
|
@Luap99 Rebased, tests passed at least once; ready for review. |
|
@TomSweeneyRedHat @nalind @rhatdan PTAL |
|
/approve |
1 similar comment
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, mheon, mtrmac, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
@Luap99 needs a rebase, but GTG once done. |
… per failures in #5929 .
What type of PR is this?
What this PR does / why we need it:
How to verify it
Existing tests + containers/podman#25007 .
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?