Add support for container initialization #491
Conversation
|
@vmsh0 The line |
|
The issue is resolved. That log was from the test that uses ssh to loopback the podman socket file to a different location in the filesystem. It simply required suitable ssh and permissions setup. I have updated my PR to include a unit test and an integration test for the new feature. Also a small docstring fix in a related place. |
vmsh0
force-pushed
the
container-init
branch
2 times, most recently
from
69ae03c to
4e79592
Compare
This commit contributes support for container initialization (i.e., the operation performed by `podman container init`.) Alongside that, it introduces: - unit test ContainersTestCase::test_init - integration subtest `Create-Init-Start Container` in ContainersIntegrationTest::test_container_crud A small fix to the docstring of Container.status has also been contributed to reflect the existance of the `created` and `initialized` states. Signed-off-by: Riccardo Paolo Bestetti <[email protected]>
|
Thanks @vmsh0 @jwhonce @umohnani8 PTAL |
|
Thanks! @vmsh0 if you are interested fixing /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inknos, rhatdan, vmsh0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Fixes: #490 |
In reference to my issue #490, I have drafted a patch to add support for the operation.
I have performed some trivial manual testing of the change, but trying to run
toxresults in the log line below repeating indefinitely, and as such I have not run the various testing facilities that the project provides.If anyone would be able to help me to get the tests running, I would be more than happy to also contribute additional coverage for this new method.