Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bump github.com/spf13/viper to 1.17.0 #1612

Merged
merged 7 commits into from
Jan 29, 2025
Merged

build: Bump github.com/spf13/viper to 1.17.0 #1612

merged 7 commits into from
Jan 29, 2025

Conversation

debarshiray
Copy link
Member

No description provided.

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jan 23, 2025
@debarshiray
build: Bump github.com/spf13/viper to 1.11.0
5a4b9f6 
The src/go.sum file was updated with 'go mod tidy'.

containers#1612
@debarshiray debarshiray force-pushed the wip/rishi/github.com-spf13-viper-1.19.0 branch from 3bd0e7c to 5a4b9f6 Compare January 23, 2025 14:29
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/6278983130594f3c8369e01c2976bc84

❌ unit-test RETRY_LIMIT in 4m 19s
❌ unit-test-migration-path-for-coreos-toolbox FAILURE in 3m 08s
❌ unit-test-restricted RETRY_LIMIT in 4m 09s
❌ system-test-fedora-rawhide-commands-options RETRY_LIMIT in 4m 15s
❌ system-test-fedora-rawhide-runtime-environment-arch-fedora RETRY_LIMIT in 4m 14s
❌ system-test-fedora-rawhide-runtime-environment-ubuntu RETRY_LIMIT in 4m 19s
❌ system-test-fedora-41-commands-options RETRY_LIMIT in 4m 27s
❌ system-test-fedora-41-runtime-environment-arch-fedora RETRY_LIMIT in 4m 11s
❌ system-test-fedora-41-runtime-environment-ubuntu RETRY_LIMIT in 4m 17s
❌ system-test-fedora-40-commands-options RETRY_LIMIT in 5m 14s
❌ system-test-fedora-40-runtime-environment-arch-fedora RETRY_LIMIT in 5m 10s
❌ system-test-fedora-40-runtime-environment-ubuntu RETRY_LIMIT in 5m 11s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jan 23, 2025
@debarshiray
build: Bump github.com/spf13/viper to 1.11.0
7fe70f8 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@debarshiray debarshiray force-pushed the wip/rishi/github.com-spf13-viper-1.19.0 branch from 5a4b9f6 to 7fe70f8 Compare January 23, 2025 16:32
@debarshiray
build: Bump github.com/spf13/viper to 1.11.0
10e1544 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@debarshiray debarshiray force-pushed the wip/rishi/github.com-spf13-viper-1.19.0 branch from 7fe70f8 to 10e1544 Compare January 23, 2025 16:45
@debarshiray debarshiray requested a review from Jmennius as a code owner January 23, 2025 16:45
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/c782f4b89a874442b019bdf980c2a61b

✔️ unit-test SUCCESS in 4m 49s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 04s
✔️ unit-test-restricted SUCCESS in 4m 40s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 22m 13s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 27m 24s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 36m 48s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 19m 29s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 28m 27s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 37m 00s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 21m 48s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 29m 46s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 39m 08s

@debarshiray debarshiray mentioned this pull request Jan 24, 2025
Merged
@debarshiray
build: Bump github.com/spf13/viper to 1.12.0
6400ff2 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/de955fc40aa847758044d73b624eddba

✔️ unit-test SUCCESS in 5m 32s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 05s
✔️ unit-test-restricted SUCCESS in 5m 46s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 16m 02s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 20m 50s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 34m 37s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 14m 03s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 20m 39s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 34m 30s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 11m 46s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 17m 17s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 32m 28s

@debarshiray
build: Bump github.com/spf13/viper to 1.13.0
9c19e2d 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/530e3bd9e915467fb1c8550f18a3f8da

✔️ unit-test SUCCESS in 5m 32s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 51s
✔️ unit-test-restricted SUCCESS in 5m 31s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 11m 02s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 18m 48s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 30m 24s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 11m 44s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 20m 11s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 32m 14s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 11m 10s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 18m 35s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 31m 08s

@debarshiray
build: Bump github.com/spf13/viper to 1.14.0
8829db6 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/b5862d6bfd7d4345b665864ef432feff

✔️ unit-test SUCCESS in 5m 47s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 56s
✔️ unit-test-restricted SUCCESS in 5m 48s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 17m 23s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 23m 06s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 35m 12s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 15m 44s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 23m 57s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 31m 38s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 15m 53s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 17m 07s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 35m 13s

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jan 24, 2025
@debarshiray
build: Bump github.com/spf13/viper to 1.15.0
05d01d4 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/6a8d1c0edc644f0aabcb561c77a3ec80

❌ unit-test FAILURE in 5m 53s
❌ unit-test-migration-path-for-coreos-toolbox FAILURE in 3m 45s
❌ unit-test-restricted FAILURE in 5m 48s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 21m 49s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 29m 02s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 37m 44s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 20m 30s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 28m 50s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 38m 25s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 21m 11s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 28m 55s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 30m 54s

@danpawlik
Copy link
Contributor

@debarshiray so it looks better now, or?

@debarshiray
Copy link
Member Author

debarshiray commented Jan 27, 2025 •
edited
Loading

@debarshiray so it looks better now, or?

Hey! Yes, setting the GOINSECURE environment variable to go.opencensus.io worked around the problem. Thanks for checking in.

@debarshiray
build: Bump github.com/spf13/viper to 1.15.0
03fd9c5 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

The src/go.sum file was skipped from the codespell test because it's
generated with 'go mod tidy'.  Otherwise codespell would complain:
  : github.com/spf13/viper v1.15.0
      h1:js3yy885G8xwJa6iOISGFwd+qlUo5AvyXb7CiihdtiU=
  > github.com/spf13/viper v1.15.0/go.mod
      h1:fFcTBJxvhhzSJiZy8n+PeW6t8l+KeT/uTARa0jHOQLA=
  : github.com/stretchr/objx v0.1.0/go.mod
      h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
  ./src/go.sum:384: KeT ==> key, kept

containers#1612
@debarshiray debarshiray force-pushed the wip/rishi/github.com-spf13-viper-1.19.0 branch from 05d01d4 to 03fd9c5 Compare January 27, 2025 13:58
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/4ba6821d85d74893b15fd3779c62bc24

✔️ unit-test SUCCESS in 5m 47s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 4m 01s
✔️ unit-test-restricted SUCCESS in 5m 47s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 20m 58s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 25m 04s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 36m 53s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 17m 58s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 24m 56s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 37m 18s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 18m 02s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 24m 53s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 37m 35s

@debarshiray
build: Bump github.com/spf13/viper to 1.16.0
5196d21 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@debarshiray
build: Bump github.com/spf13/viper to 1.17.0
bff269a 
The indirect dependencies in the src/go.mod file, and the src/go.sum
file were updated with 'go mod tidy'.

containers#1612
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/2ad76911dc14456cbb3d5b2e7b882b10

✔️ unit-test SUCCESS in 5m 40s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 35s
✔️ unit-test-restricted SUCCESS in 5m 21s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 16m 18s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 21m 51s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 33m 31s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 14m 23s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 21m 44s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 34m 10s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 14m 58s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 23m 31s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 30m 43s

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/8d066a5d2a0c40bfa3128e4e93bb1e7d

✔️ unit-test SUCCESS in 5m 45s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 43s
✔️ unit-test-restricted SUCCESS in 5m 35s
✔️ system-test-fedora-rawhide-commands-options SUCCESS in 1h 18m 57s
✔️ system-test-fedora-rawhide-runtime-environment-arch-fedora SUCCESS in 1h 25m 01s
✔️ system-test-fedora-rawhide-runtime-environment-ubuntu SUCCESS in 35m 12s
✔️ system-test-fedora-41-commands-options SUCCESS in 1h 16m 59s
✔️ system-test-fedora-41-runtime-environment-arch-fedora SUCCESS in 1h 24m 57s
✔️ system-test-fedora-41-runtime-environment-ubuntu SUCCESS in 35m 25s
✔️ system-test-fedora-40-commands-options SUCCESS in 1h 17m 26s
✔️ system-test-fedora-40-runtime-environment-arch-fedora SUCCESS in 1h 17m 08s
✔️ system-test-fedora-40-runtime-environment-ubuntu SUCCESS in 31m 33s

@debarshiray debarshiray merged commit bff269a into containers:main Jan 29, 2025
3 checks passed
@debarshiray
Copy link
Member Author

Let's only bump Viper to 1.17.0 for now, because Fedora 41 and 40 are in the process of updating it from 1.17.0 to 1.19.0.

@debarshiray debarshiray changed the title build: Bump github.com/spf13/viper to 1.19.0 build: Bump github.com/spf13/viper to 1.17.0 Jan 29, 2025
@debarshiray debarshiray deleted the wip/rishi/github.com-spf13-viper-1.19.0 branch January 29, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarryMichal HarryMichal Awaiting requested review from HarryMichal HarryMichal is a code owner

@Jmennius Jmennius Awaiting requested review from Jmennius

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debarshiray @danpawlik