Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: getting started on gromacs #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wip: getting started on gromacs #2

wants to merge 1 commit into from

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Feb 21, 2024

We can likely move forward testing lammps, but I thought I'd give a quick shot at gromacs. There are many more libraries here (and the main executable is gmx) and the executable seemed to work ok, but I got an error for libgromacs:

image

We can debug this if/when needed.

@al42and
Copy link

al42and commented Feb 23, 2024

Hi! Hope you don't mind me barging in.

If I understand correctly, this project aims to offer a nice way to JIT the code for the target hardware, right? If so, GROMACS is perhaps not the best subject if a performance benefit is expected. GROMACS uses explicit SIMD for all the hot code (not in md5.c, though; not sure what's wrong with it) configured by setting -DGMX_SIMD=... in CMake. It is only possible to choose one SIMD backend at a time, and I doubt LLVM is smart enough to convert, say, SSE4 intrinsics into optimal AVX512 intrinsics or vice-versa. The rest of the code might benefit from JIT, but I would not expect an impact on the overall MD performance remotely comparable with compiling with the optimal GMX_SIMD set. Analysis tools might get faster, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants