Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playbooks: refactor(cxl-ui): cxl-like-or-dislike ~> cxl-vote #174

Open
lkraav opened this issue Sep 29, 2021 · 2 comments
Open

playbooks: refactor(cxl-ui): cxl-like-or-dislike ~> cxl-vote #174

lkraav opened this issue Sep 29, 2021 · 2 comments

Comments

@lkraav
Copy link

lkraav commented Sep 29, 2021

During original development, all component internals were correctly named around "vote" concept, as seen in https://github.com/conversionxl/aybolit/blob/62ec7f1db7aab914189671e2041779e7a692c527/packages/cxl-ui/src/components/cxl-like-or-dislike.js

It is highly surprising then that the component name itself ended up something rather awkward like "cxl-like-or-dislike", paving the way in the future for something like "cxl-like-or-dislike-or-maybe-something-third-or-fourth-and-fifth"?

I didn't have bandwidth to dig through internals at the time, but would like to ask: do we have bandwidth to clean this up pre-launch?

@heshfekry
Copy link

Does this refactor need to happen anymore? this is a deprecated feature.

@lkraav
Copy link
Author

lkraav commented May 3, 2022

Does this refactor need to happen anymore? this is a deprecated feature.

I think it can still be used elsewhere on the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants