Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cxl-ui): rename 'cxl-like-or-dislike' to 'cxl-vote' #191

Closed
wants to merge 1 commit into from
Closed

refactor(cxl-ui): rename 'cxl-like-or-dislike' to 'cxl-vote' #191

wants to merge 1 commit into from

Conversation

anoblet
Copy link
Collaborator

@anoblet anoblet commented Jan 25, 2022 •
edited
Loading

@anoblet anoblet marked this pull request as ready for review January 25, 2022 20:34
@lkraav
Copy link

lkraav commented Jan 26, 2022

Shouldn't target branch be playbooks?

@pawelkmpt pawelkmpt changed the base branch from develop to playbooks January 26, 2022 09:27
@pawelkmpt
Copy link

Shouldn't target branch be playbooks?

Indeed. I just changed it @lkraav and see conflicts. @anoblet can you take a look?

@anoblet anoblet force-pushed the anoblet/refactor/cxl-vote branch from cc27cb4 to b0e6612 Compare January 26, 2022 15:22
@github-actions
Copy link

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js 41.37 KB (-0.02% 🔽)

@anoblet anoblet requested review from lkraav and pawelkmpt January 26, 2022 15:25
@anoblet
Copy link
Collaborator Author

anoblet commented Jan 26, 2022 •
edited
Loading

Fixed :)

@lkraav lkraav changed the base branch from playbooks to master August 12, 2022 18:23
@lkraav
Copy link

lkraav commented Aug 12, 2022 •
edited
Loading

Since playbooks got merged, I switched branch back to master. Conflicts?

@pawelkmpt
Copy link

We're not using it anymore.

@pawelkmpt pawelkmpt closed this Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saas786 saas786 Awaiting requested review from saas786

@lkraav lkraav Awaiting requested review from lkraav

@pawelkmpt pawelkmpt Awaiting requested review from pawelkmpt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anoblet @lkraav @pawelkmpt