This repository has been archived by the owner on Jan 17, 2020. It is now read-only.
Use escapedName to generate valid library YAML #116
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #100
When a library info entry is generated via the
updateLicenses
task, if the library's name contains a colon (:
), the resulting output is invalidly-formatted YAML:This invalid YAML prevents the
licenses.yml
file from being properly parsed by thecheckLicenses
,generateLicensePage
, andgenerateLicenseJson
tasks:PR #59 introduced a function for handling library names with colons, but use of that function appears to have been unintentionally not carried over in PR #86.
This PR utilizes
escapedName
from #59 so that library names with colons are surrounded with quotes: