-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: test and advertise Python 3.12 support #1387
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1387 +/- ##
==========================================
+ Coverage 97.27% 97.41% +0.13%
==========================================
Files 48 48
Lines 4327 4327
==========================================
+ Hits 4209 4215 +6
+ Misses 118 112 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
1993745
to
93be3c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for caring about this maintenance work, @noirbizarre! 🙏
I believe you just ran poetry lock
or poetry update
, right? It seems only pywin32
needed an update though. I'd prefer not mixing a complete lock file update with adding support for Python 3.12. Would you mind reverting poetry.lock
and trying to update only pywin32
through poetry update pywin32
?
By the way, I think the tests are failing now because of the most recent mypy version. See also #1286 (comment). |
93be3c8
to
85b80ab
Compare
Yep, exactly. PR updated with minimal lock change. |
40f30b1
to
9b38f15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One CI job is failing though, I'm not quite sure why. It seems to be related to the pip vendored by Python 3.12. pypa/pip#11501 looks like the same problem. I wonder why only the Ubuntu job is failing. |
Head branch was pushed to by a user without write access
9b38f15
to
9b8cfcc
Compare
9b8cfcc
to
a531c80
Compare
I think Now CI is green 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks for investigating that problem! 👌
LGTM! 🎉 Thanks again for engaging also in this maintenance work, much appreciated! 🙏
I try to contribute as much as possible to tools I use, even for small tasks. |
A basic pull request adding Python 3.12 to tested versions as well as proper PyPI classifiers for Python 3.12 support advertisement.
No functional changes