Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: test and advertise Python 3.12 support #1387

Merged
merged 1 commit into from
Oct 28, 2023

Conversation

noirbizarre
Copy link
Contributor

A basic pull request adding Python 3.12 to tested versions as well as proper PyPI classifiers for Python 3.12 support advertisement.

No functional changes

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1387 (a531c80) into master (23f9366) will increase coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1387      +/-   ##
==========================================
+ Coverage   97.27%   97.41%   +0.13%     
==========================================
  Files          48       48              
  Lines        4327     4327              
==========================================
+ Hits         4209     4215       +6     
+ Misses        118      112       -6     
Flag Coverage Δ
unittests 97.41% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tests/test_updatediff.py 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for caring about this maintenance work, @noirbizarre! 🙏

I believe you just ran poetry lock or poetry update, right? It seems only pywin32 needed an update though. I'd prefer not mixing a complete lock file update with adding support for Python 3.12. Would you mind reverting poetry.lock and trying to update only pywin32 through poetry update pywin32?

@sisp
Copy link
Member

sisp commented Oct 27, 2023

By the way, I think the tests are failing now because of the most recent mypy version. See also #1286 (comment).

@noirbizarre
Copy link
Contributor Author

Yep, exactly. PR updated with minimal lock change.
Sorry for the multiple trials, I don't have other mean to test against Windows and MacOS.

@noirbizarre noirbizarre force-pushed the python/3.12 branch 2 times, most recently from 40f30b1 to 9b38f15 Compare October 27, 2023 20:47
@yajo yajo enabled auto-merge (squash) October 28, 2023 02:38
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sisp
Copy link
Member

sisp commented Oct 28, 2023

One CI job is failing though, I'm not quite sure why. It seems to be related to the pip vendored by Python 3.12. pypa/pip#11501 looks like the same problem. I wonder why only the Ubuntu job is failing.

auto-merge was automatically disabled October 28, 2023 10:24

Head branch was pushed to by a user without write access

@noirbizarre
Copy link
Contributor Author

noirbizarre commented Oct 28, 2023

I think virtualenv needed an update, so I just did poetry update virtualenv (virtualenv dependency comes from pre-commit and was the one providing the vendored pip for commitizen).
For reference, the idea comes from pre-commit/pre-commit#3041

Now CI is green 🎉

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks for investigating that problem! 👌

LGTM! 🎉 Thanks again for engaging also in this maintenance work, much appreciated! 🙏

@sisp sisp merged commit 9ea980f into copier-org:master Oct 28, 2023
20 checks passed
@noirbizarre noirbizarre deleted the python/3.12 branch October 28, 2023 11:25
@noirbizarre
Copy link
Contributor Author

I try to contribute as much as possible to tools I use, even for small tasks.
Given I contribute to those tools, I benefit too from housekeeping and maintenance.
Anyway, I'm pleased to help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants