Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] update dependencies to lasted colorama #1403

Merged

Conversation

celm1990
Copy link
Contributor

After this PR #1379 method just_fix_windows_console is used instead of init So is need install colorama>=0.4.6 because this method is add in commit tartley/colorama@5f1794d
otherwise raise error
AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, @celm1990, and thanks for the PR! 🙏

Could you please run poetry lock --no-update to update the lock file (the content hash of pyproject.toml in there)? Poetry currently warns:

Warning: poetry.lock is not consistent with pyproject.toml. You may be getting improper dependencies. Run `poetry lock [--no-update]` to fix it.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1403 (7d8927e) into master (5827d6a) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1403   +/-   ##
=======================================
  Coverage   97.44%   97.44%           
=======================================
  Files          48       48           
  Lines        4423     4426    +3     
=======================================
+ Hits         4310     4313    +3     
  Misses        113      113           
Flag Coverage Δ
unittests 97.44% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

After this PR copier-org#1379   method `just_fix_windows_console` is used instead of `init` So is need install `colorama>=0.4.6` because this method is add in commit tartley/colorama@5f1794d
otherwise raise error
AttributeError: module 'colorama' has no attribute 'just_fix_windows_console'
@celm1990 celm1990 force-pushed the fix-colorama-just_fix_windows_console branch from f35cd0d to 7d8927e Compare November 11, 2023 14:32
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks! LGTM! 🎉

@sisp sisp enabled auto-merge (squash) November 11, 2023 14:37
@sisp sisp merged commit a0770ef into copier-org:master Nov 11, 2023
19 checks passed
@celm1990 celm1990 deleted the fix-colorama-just_fix_windows_console branch November 11, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants