Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'pygrep' lint group #1505

Merged
merged 2 commits into from
Feb 11, 2024
Merged

add 'pygrep' lint group #1505

merged 2 commits into from
Feb 11, 2024

Conversation

danieleades
Copy link
Contributor

@danieleades danieleades commented Feb 6, 2024

what is says on the tin

  • reduces the scope of mypy errors
  • prevents accidentally 'hiding' new errors due to blanket lint suppression

Copy link

codecov bot commented Feb 11, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5aa0273) 97.46% compared to head (7eae2aa) 97.46%.
Report is 4 commits behind head on master.

Files Patch % Lines
devtasks.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
  Coverage   97.46%   97.46%           
=======================================
  Files          48       48           
  Lines        4537     4537           
=======================================
  Hits         4422     4422           
  Misses        115      115           
Flag Coverage Δ
unittests 97.46% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a minor Ruff linting error:

devtasks.py:63:9: PGH002 `warn` is deprecated in favor of `warning`

@danieleades
Copy link
Contributor Author

There's a minor Ruff linting error:

devtasks.py:63:9: PGH002 `warn` is deprecated in favor of `warning`

should be resolved now.

Oddly, i couldn't reproduce this error locally using poetry run ruff check .

@danieleades danieleades requested a review from sisp February 11, 2024 13:01
Copy link
Member

@sisp sisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thanks, @danieleades! 🙏

@sisp sisp merged commit 74bba54 into copier-org:master Feb 11, 2024
20 of 21 checks passed
@danieleades danieleades deleted the ruff-pygrep branch February 11, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants