-
-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 'flake-future-annotations' lint group #1506
Conversation
i've removed some type aliases on the basis that (especially with the modern syntax allowed by the
personally i'm inclined to remove the 'sequence' type aliases as well but thought that might be ever so slightly more controversial |
4e64f2a
to
5b2b541
Compare
i've gone ahead and removed the |
8e1236d
to
3497493
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely, thanks! ❤️
It seems there are test failures, could you fix them please? |
hmm this is a bug i've not run into before. The it would be nice to remove |
3497493
to
26d724e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danieleades Would you mind addressing #1513 (review) and then rebasing this PR first?
i've addressed that comment. I'll rebase this PR once that's merged |
26d724e
to
701cb34
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1506 +/- ##
==========================================
- Coverage 97.46% 97.34% -0.13%
==========================================
Files 48 48
Lines 4543 4557 +14
==========================================
+ Hits 4428 4436 +8
- Misses 115 121 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3ec0261
to
755409d
Compare
b6b4021
to
fa91c72
Compare
dc1afbd
to
14a6731
Compare
a9f2a9b
to
14a6731
Compare
note for reviewers- I haven't been able to get the Nix environment working, so i'm not running the same I take it the CI isn't checking the formatting? That would solve this problem for me- I could manually apply the changes if the CI showed a diff |
allows using more modern typing syntax without sacrificing compatibility