Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modem status functionality to UART class #980

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

cognitivegears
Copy link
Contributor

This PR adds modem status functionality to UART.js. A couple of use cases for this:

  1. Running a retro BBS system or BBS door game within a browser or node.js
  2. Running old DOS modem terminal programs - part of what is needed for Issue DOS dialup terminal to websocket gateway #138

...or anything else that uses the UART that expects flags such as carrier detect, etc to be set.

Copy link
Owner

@copy copy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Running a retro BBS system or BBS door game within a browser or node.js

That sounds pretty cool, is this something you've been working on?

The code looks good, I've left two small suggestions. Before merging, could you do a quick pass to make sure the style is the same as adjacent code (i.e. indentation, newline between ) and {?

src/browser/starter.js Show resolved Hide resolved
src/uart.js Outdated Show resolved Hide resolved
@cognitivegears
Copy link
Contributor Author

Thanks!

Running a retro BBS system or BBS door game within a browser or node.js

That sounds pretty cool, is this something you've been working on?

It is :) I'm a contributor to Enigma 1/2 BBS - https://github.com/NuSkooler/enigma-bbs which is a BBS written in node.js. One of the toughest things to do with it is setting up BBS Door games. It has to shell out to an emulator. So instead, I'd like to use v86 to run the BBS DOS door game directly.

foodfight

This requires a change like this though, because most Door games check the carrier detect to see if someone has hung up.

The code looks good, I've left two small suggestions. Before merging, could you do a quick pass to make sure the style is the same as adjacent code (i.e. indentation, newline between ) and {?

Will do, I ended up a little busy with work this week but should be able to finish this off this weekend. More to come.

@copy copy merged commit 8064e19 into copy:master Jan 31, 2024
3 checks passed
@copy
Copy link
Owner

copy commented Jan 31, 2024

It is :) I'm a contributor to Enigma 1/2 BBS - https://github.com/NuSkooler/enigma-bbs which is a BBS written in node.js. One of the toughest things to do with it is setting up BBS Door games. It has to shell out to an emulator. So instead, I'd like to use v86 to run the BBS DOS door game directly.

That's very cool :-)

Thanks for the contribution, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants