Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo for labels in README.md #188

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Fix typo for labels in README.md #188

merged 2 commits into from
Jan 14, 2025

Conversation

Javex
Copy link
Contributor

@Javex Javex commented Jan 13, 2025

Why is this pull request needed and what does it do?

"labels" is plural.

Which issues (if any) are related?

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

"labels" is plural

Signed-off-by: javex <[email protected]>
@hagaibarel
Copy link
Collaborator

Thanks for the PR!

You'll need to bump the chart version (see the failed check) and also update the annotations field in the Chart.yaml with the change

@Javex
Copy link
Contributor Author

Javex commented Jan 14, 2025

Okay done!

@hagaibarel hagaibarel merged commit 59fa883 into coredns:master Jan 14, 2025
2 checks passed
@hagaibarel
Copy link
Collaborator

Okay done!

Great, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants